Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support list for opensearch_version in PluginStats #568

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Feb 29, 2024

Description

Support list for opensearch_version in PluginStats. Fixes failing tests against unreleased OpenSearch 2.x & main.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Xtansia Xtansia force-pushed the fix/plugin-opensearch-version-as-list branch from 17ebbeb to acffe9b Compare February 29, 2024 23:37
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a breaking change being introduced in 2.13? That shouldn't be the case.

@Xtansia
Copy link
Collaborator Author

Xtansia commented Mar 3, 2024

Is there a breaking change being introduced in 2.13? That shouldn't be the case.

@dblock It's a result of this backport: opensearch-project/OpenSearch#12271

@dblock
Copy link
Member

dblock commented Mar 4, 2024

It's a bug, I opened opensearch-project/OpenSearch#12528. Can we avoid this breakage in a different way (mark it pending?).

@Xtansia
Copy link
Collaborator Author

Xtansia commented Mar 4, 2024

It's a bug, I opened opensearch-project/OpenSearch#12528. Can we avoid this breakage in a different way (mark it pending?).

What exactly do you mean by "mark it pending"? Change the PR to Draft? As presumably we'll still need these changes as the breakage will remain in 3.x?

@dblock
Copy link
Member

dblock commented Mar 4, 2024

What exactly do you mean by "mark it pending"? Change the PR to Draft? As presumably we'll still need these changes as the breakage will remain in 3.x?

I mean our build is broken here without this change and we need a workaround, not support for an array. I believe that was a side-effect/mistake and we will not be making a breaking change in 3.0, but I could be wrong.

@Xtansia Xtansia marked this pull request as draft March 4, 2024 21:55
@Xtansia Xtansia closed this Mar 24, 2024
@Xtansia Xtansia deleted the fix/plugin-opensearch-version-as-list branch March 24, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants