Fix issue with conflicting User annotations #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhenii Tiutiunnyk <[email protected]>
evheniyt
requested review from
idanl21,
swoehrl-mw,
prudhvigodithi,
jochenkressin,
pchmielnik and
salyh
as code owners
swoehrl-mw
requested changes
Nov 12, 2024
docs/userguide/main.md
Outdated
Comment on lines
1149
to
1150
| Also, it is possible to store multiple Users password in the same Secret. To do this, you should create a secret where | ||
| each key will be equal to a username and value is a user password. |
There was a problem hiding this comment.
Please rewrite this to make it clearer that if multiple passwords are stored in one secret it must be done this way because the operator expects it. Right now it sounds like a suggestion, but the way you have written the code it would not work correctly otherwise.
Signed-off-by: Yevhenii Tiutiunnyk <[email protected]>
swoehrl-mw
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correctly set annotations for Secret that stores multiple User passwords.
OsUserNameAnnotationwill be assigned only to the Secret that is storing the password for a single user. Otherwise, if Secret is used by multiple Users this annotation will be skipped.To support correct reconciliation for multi-user Secret, I have added iteration over
secretObj.Data.In the case of multi-user Secret, reconciliation will work only if the Secret keys correspond to the User name. So in theory there could be a breaking change here for people who are using multi-user Secret and have different Secret keys and User names.
Issues Resolved
Closes #884
Check List
make lint)Please refer to the PR guidelines before submitting this pull request.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.