feat(helm): add option to set resources for initHelper #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guilherme Oki <[email protected]>
guilhermeoki
requested review from
idanl21,
dbason,
swoehrl-mw,
prudhvigodithi,
jochenkressin,
pchmielnik and
salyh
as code owners
swoehrl-mw
requested changes
Aug 7, 2024
There was a problem hiding this comment.
Hi @guilhermeoki. Thank you for your contribution. Please see my inline comment.
Also, I know you only added the resources part, but could you please add the entire initHelper struct to the values.yaml of the chart to show that it is possible to set it?
Comment on lines
30
to
50
| {{- if .Values.opensearchCluster.initHelper.resources }} | ||
| resources: | ||
| {{- if .Values.opensearchCluster.initHelper.resources.requests }} | ||
| requests: | ||
| {{- if .Values.opensearchCluster.initHelper.resources.requests.memory }} | ||
| memory: {{ .Values.opensearchCluster.initHelper.resources.requests.memory }} | ||
| {{- end }} | ||
| {{- if .Values.opensearchCluster.initHelper.resources.requests.cpu }} | ||
| cpu: {{ .Values.opensearchCluster.initHelper.resources.requests.cpu }} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- if .Values.opensearchCluster.initHelper.resources.limits }} | ||
| limits: | ||
| {{- if .Values.opensearchCluster.initHelper.resources.limits.memory }} | ||
| memory: {{ .Values.opensearchCluster.initHelper.resources.limits.memory }} | ||
| {{- end }} | ||
| {{- if .Values.opensearchCluster.initHelper.resources.limits.cpu }} | ||
| cpu: {{ .Values.opensearchCluster.initHelper.resources.limits.cpu }} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- end }} |
There was a problem hiding this comment.
This could be simplified like this:
{{- if .Values.opensearchCluster.initHelper.resources }}
resources:
{{- toYaml .Values.opensearchCluster.initHelper.resources | nindent 6 }}
{{- end }}
There was a problem hiding this comment.
Also, I know you only added the resources part, but could you please add the entire initHelper struct to the values.yaml of the chart to show that it is possible to set it?
Sure! I will add the struct to the values.yaml
There was a problem hiding this comment.
This could be simplified like this:
Ok! I will simplify that part.
Signed-off-by: Guilherme Oki <[email protected]>
guilhermeoki
force-pushed
the
feat/add-resources-init-helper
branch
from
eaad80a
to
c4269ab
Compare
swoehrl-mw
approved these changes
Aug 13, 2024
rkthtrifork
pushed a commit
to trifork/opensearch-k8s-operator
that referenced
this pull request
Aug 21, 2024
…oject#865) ### Description This PR adds an option to define resources for initHelper container. ### Issues Resolved Closes this issue opensearch-project#866 ### Check List - [X] Commits are signed per the DCO using --signoff - [X] Unittest added for the new/changed functionality and all unit tests are successful - [X] Customer-visible features documented - [X] No linter warnings (`make lint`) By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Guilherme Oki <[email protected]>
rkthtrifork
pushed a commit
to trifork/opensearch-k8s-operator
that referenced
this pull request
Aug 21, 2024
…oject#865) ### Description This PR adds an option to define resources for initHelper container. ### Issues Resolved Closes this issue opensearch-project#866 ### Check List - [X] Commits are signed per the DCO using --signoff - [X] Unittest added for the new/changed functionality and all unit tests are successful - [X] Customer-visible features documented - [X] No linter warnings (`make lint`) By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Guilherme Oki <[email protected]>
rkthtrifork
pushed a commit
to trifork/opensearch-k8s-operator
that referenced
this pull request
Aug 21, 2024
…oject#865) ### Description This PR adds an option to define resources for initHelper container. ### Issues Resolved Closes this issue opensearch-project#866 ### Check List - [X] Commits are signed per the DCO using --signoff - [X] Unittest added for the new/changed functionality and all unit tests are successful - [X] Customer-visible features documented - [X] No linter warnings (`make lint`) By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Guilherme Oki <[email protected]> Signed-off-by: rkthtrifork <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an option to define resources for initHelper container.
Issues Resolved
Closes this issue #866
Check List
make lint)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.