Add ability to Set PodManagementPolicy specific to Nodegroup from Specs #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iam404
requested review from
idanl21,
dbason,
swoehrl-mw,
prudhvigodithi,
jochenkressin,
pchmielnik and
salyh
as code owners
iam404
force-pushed
the
custom-podmanagementpolicy
branch
from
f37a1fa
to
8848855
Compare
Signed-off-by: Prabuddha Chakraborty <[email protected]> Signed-off-by: Prabuddha Chakrborty <[email protected]>
… to Parallel Signed-off-by: Prabuddha Chakraborty <[email protected]> Signed-off-by: Prabuddha Chakrborty <[email protected]>
iam404
force-pushed
the
custom-podmanagementpolicy
branch
from
8848855
to
dede5ec
Compare
Signed-off-by: Prabuddha Chakrborty <[email protected]>
|
Thanks @iam404 AFAIK there was a reason for using |
|
The way the operator is implemented right now it depends on the OrderedReady to bring up a new cluster one by one. What is valid to discuss is if we could also implement it in a way to bring up a cluster in parallel and have that stable (AFAIK bootstrapping a new cluster in parallel led to unstable behaviour so it was done with OrderedReady). But regardless, that should be an internal decision of the operator logic and not something the user can configure. @prudhvigodithi IMO this PR should not be merged. |
|
Closing as I don't think this PR should be merged, see my last comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ability to Set PodManagementPolicy for Node groups. Default to OrderedReady.
PodManagementPolicy controls how pods are created during initial scale up, when replacing pods on nodes, or when scaling down. The default policy is
OrderedReady. This PR will help to setParallelmode where pods are created in parallel to match the desired scale without waiting.OpenSearch Operator is already managing deletion ordering itself, it wont matter much to have Parallel.
If we look at the official helm chart of OpenSearch its already set to
Parallelby default.Also, for specs with PodManagementPolicy = Parallel, the recoverymode logic is bypassed.
Issues Resolved
Check List
make lint)If CRDs are changed:
make manifests) and also copied into the helm chartPlease refer to the PR guidelines before submitting this pull request.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.