Add PodDisruptionBudget for NodePools #547
Conversation
| } | ||
|
|
||
| } | ||
| } |
There was a problem hiding this comment.
This needs an else to delete a potentially existing PDB if enable is set to false
There was a problem hiding this comment.
Else case is still missing
There was a problem hiding this comment.
Deletion is still not handled, is it?
There was a problem hiding this comment.
Else with deletion is not handled
| @@ -4334,6 +4334,70 @@ spec: | |||
| additionalProperties: | |||
| type: string | |||
| type: object | |||
| pdb: | |||
There was a problem hiding this comment.
The change also needs to be copied into the helm chart
There was a problem hiding this comment.
CRD changes have not been copied to helm chart
There was a problem hiding this comment.
Changes have still not been copied to the helm chart
| @@ -4334,6 +4334,70 @@ spec: | |||
| additionalProperties: | |||
| type: string | |||
| type: object | |||
| pdb: | |||
There was a problem hiding this comment.
CRD changes have not been copied to helm chart
| } | ||
|
|
||
| } | ||
| } |
There was a problem hiding this comment.
Else case is still missing
Co-authored-by: Sebastian Woehrl <[email protected]>
| } | ||
|
|
||
| } | ||
| } |
There was a problem hiding this comment.
Else with deletion is not handled
| @@ -4334,6 +4334,70 @@ spec: | |||
| additionalProperties: | |||
| type: string | |||
| type: object | |||
| pdb: | |||
There was a problem hiding this comment.
Changes have still not been copied to the helm chart
Signed-off-by: Sebastian Woehrl <[email protected]>
Signed-off-by: Sebastian Woehrl <[email protected]>
Signed-off-by: Sebastian Woehrl <[email protected]>
for opensearch-project#391 --------- Signed-off-by: Sebastian Woehrl <[email protected]> Co-authored-by: Sebastian Woehrl <[email protected]>
for opensearch-project#391 --------- Signed-off-by: Sebastian Woehrl <[email protected]> Co-authored-by: Sebastian Woehrl <[email protected]>
for #391