-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added option to use emptyDir as additional mount #512
Conversation
@mdarii |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mdarii.
Thank you for your contribution.
I have some comments:
- Please add a unittest for the new functionality to verify it works (you can extend the test in
controllers/cluster_test.go
by adding an additionalVolume to the spec and verifying the volume(mount) is part of the created STS). - Extend the section on "Additional Volumes" in the userguide
- Extend the CRD reference (
docs/designs/crd.md
)
Hi @swoehrl-mw , I've updated my PR. |
@mdarii Code looks good, please check why the tests fail and fix if necessary. |
@swoehrl-mw I'll look into it, but most probably next week |
@swoehrl-mw looks like I've found typo, can you please retrigger pipeline? |
@mdarii Could you please merge in the current main? There is a fix that should deal with the failing functionaltests check so we can then hopefully merge this PR. |
@mdarii |
yes, I'll try to come back to it somehow this week |
Signed-off-by: mdarii <[email protected]>
Signed-off-by: mdarii <[email protected]>
Signed-off-by: mdarii <[email protected]>
Signed-off-by: mdarii <[email protected]>
Signed-off-by: mdarii <[email protected]>
@swoehrl-mw could you trigger pipeline please, I've synced repo with master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
related to issue: #484
This commit would allow to add additional volumes as emptyDir, this is necessary if
readOnlyRootFilesystem=true