Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCI] Fixed a warning about unmet peer dependency @babel/core #466

Closed
wants to merge 3 commits into from

Conversation

Wielmany
Copy link
Contributor

@Wielmany Wielmany commented Apr 1, 2023

Description

Fixed a warning about unmet peer dependency
warning " > @babel/[email protected]" has unmet peer dependency "@babel/core@>=7.11.0"

Issues Resolved

Closes #460

Check List

  • New functionality includes testing.
    • All tests pass
  • Linter check was successfull - yarn run lint doesn't show any errors
  • Commits are signed per the DCO using --signoff
  • Changelog was updated.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Didar Tursunov <[email protected]>
Signed-off-by: Didar Tursunov <[email protected]>
Signed-off-by: Didar Tursunov <[email protected]>
@Wielmany
Copy link
Contributor Author

Wielmany commented Apr 1, 2023

Seems like @caniuse-lite didn't pass the license check due to it being CC-BY-4.0 (although from what i see, it didn't change the license, and the the bumping of 1.0.30001469 ) didn't have any issues back then

@nhtruong
Copy link
Collaborator

nhtruong commented Apr 3, 2023

@Wielmany If @caniuse-lite's version was bumped, do you think locking it to the previous version would fix this? Maybe we can include that in this PR too?

@nhtruong
Copy link
Collaborator

nhtruong commented Apr 3, 2023

These 2 PRs: #468 and #467 created and merged today didn't run into this issue though. So maybe it's coming from @babel/core?

@Wielmany
Copy link
Contributor Author

Wielmany commented Apr 4, 2023

These 2 PRs: #468 and #467 created and merged today didn't run into this issue though. So maybe it's coming from @babel/core?

Seems like it, the license check did pass without it
So @babel/core pulls some other versions on caniuse-lite and they fail a license check? I'm still not sure why it would pass in the PR before

@nhtruong
Copy link
Collaborator

@Wielmany Sometimes after awhile, the dependency errors will just resolve itself. Redo this and see if the problem has been resolved?

@Wielmany
Copy link
Contributor Author

I seem to still get an unmet dependency warning when running yarn install on a newly created branch (created from the latest main branch) image
It doesn't appear if you switch to a new branch with @babel/core installed
image
License check is still failing, as seen here

@Wielmany Wielmany marked this pull request as draft April 19, 2023 16:07
@nhtruong
Copy link
Collaborator

@Wielmany Closing this since we have a few updates regarding dependencies since. So this has gotten stale. Feel free to reopen or create a new PR.

@nhtruong nhtruong closed this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CCI] Unmet peer dependency warning
2 participants