Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Update types in package.json #461

Closed

Conversation

zloiadil
Copy link

Description

Updated and the new types are api/new.d.ts

Issues Resolved

#204
Closes [204].

Check List

  • [ yes] New functionality includes testing.
    • [ yes] All tests pass
  • [ yes] Linter check was successfull - yarn run lint doesn't show any errors
  • [ yes] Commits are signed per the DCO using --signoff
  • [ yes] Changelog was updated.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ilikmeister and others added 3 commits March 26, 2023 16:21
Signed-off-by: Iliyas <[email protected]>
Co-authored-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: Adil Bektursunov <[email protected]>
Signed-off-by: Adil Bektursunov <[email protected]>
@zloiadil zloiadil changed the title update types in package.json [fix]update types in package.json Mar 26, 2023
@zloiadil zloiadil changed the title [fix]update types in package.json [fix] Update types in package.json Mar 26, 2023
@zloiadil
Copy link
Author

@nhtruong @harshavamsi Can you please review this PR

@nhtruong
Copy link
Collaborator

The file changes are not relevant to the description of this PR. Please check your commits.

@dblock
Copy link
Member

dblock commented Mar 27, 2023

@zloiadil you just need to rebase - this might be helpful - https://code.dblock.org/2015/08/31/getting-out-of-your-first-git-mess.html

@nhtruong nhtruong added the CCI College Contributor Initiative label Mar 28, 2023
@nhtruong nhtruong closed this Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCI College Contributor Initiative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants