Skip to content

Commit

Permalink
Disabled fail_ci_if_error (#756)
Browse files Browse the repository at this point in the history
Upgraded codecov-action from v2 to v4

Signed-off-by: Theo Truong <[email protected]>
  • Loading branch information
nhtruong authored Apr 19, 2024
1 parent 3853616 commit 1138ed8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
uses: codecov/codecov-action@v4
with:
files: ./coverage.lcov
fail_ci_if_error: true
fail_ci_if_error: false

- name: Code coverage 90%
run: |
Expand Down
5 changes: 3 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
### Dependencies
- Bumps `@types/node` from 20.12.5 to 20.12.7
### Changed
- Disabled fail_ci_if_error for upload coverage step in coverage workflow ([#755](https://github.com/opensearch-project/opensearch-js/issues/755)
### Deprecated
### Removed
### Fixed
Expand All @@ -19,7 +20,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Bumps `@types/node` from 20.11.25 to 20.12.5
- Bumps `@babel/eslint-parser` from 7.23.10 to 7.24.1
### Changed
- Added `search_pipeline` ([716](https://github.com/opensearch-project/opensearch-js/pull/716))
- Added `search_pipeline` ([#716](https://github.com/opensearch-project/opensearch-js/pull/716))
### Deprecated
### Removed
### Fixed
Expand Down Expand Up @@ -257,4 +258,4 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)

### Fixed

- Fix mutability of connection headers ([#291](https://github.com/opensearch-project/opensearch-js/issues/291))
- Fix mutability of connection headers ([#291](https://github.com/opensearch-project/opensearch-js/issues/291))

0 comments on commit 1138ed8

Please sign in to comment.