Generate CreateSnapshot(Fix CreateSnapshotResponse deserialization when wait_for_completion is false) #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tatsuya Kawakami <[email protected]>
hogesako
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli,
VachaShah and
Xtansia
as code owners
hogesako
changed the title
Signed-off-by: Tatsuya Kawakami <[email protected]>
hogesako
force-pushed
the
generate-create-snapshot
branch
from
e837f5e to
66b4322
Compare
Xtansia
approved these changes
Nov 27, 2024
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-java/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/opensearch-java/backport-2.x
# Create a new branch
git switch --create backport/backport-1332-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d3509b5491c4d7caf0c842546136be92fe53022f
# Push it to GitHub
git push --set-upstream origin backport/backport-1332-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-java/backport-2.xThen, create a pull request where the |
|
@hogesako Could you please manually backport this to |
hogesako
added a commit
to hogesako/opensearch-java
that referenced
this pull request
Dec 2, 2024
…en wait_for_completion is false) (opensearch-project#1332) * Generate CreateSnapshot Signed-off-by: Tatsuya Kawakami <[email protected]> * add changelog Signed-off-by: Tatsuya Kawakami <[email protected]> --------- Signed-off-by: Tatsuya Kawakami <[email protected]> (cherry picked from commit d3509b5)
Xtansia
pushed a commit
that referenced
this pull request
Dec 2, 2024
…en wait_for_completion is false) (#1332) (#1335) * Generate CreateSnapshot Signed-off-by: Tatsuya Kawakami <[email protected]> * add changelog Signed-off-by: Tatsuya Kawakami <[email protected]> --------- Signed-off-by: Tatsuya Kawakami <[email protected]> (cherry picked from commit d3509b5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generate CreateSnapshot(Fix deserialization CreateSnapshotResponse when wait_for_completion is false)
Issues Resolved
#418
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.