Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate toBuilder and Builder.copy methods #1300

Merged

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Nov 18, 2024

Description

Generate toBuilder and Builder.copy methods

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dblock
dblock previously approved these changes Nov 19, 2024
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward.

@Xtansia Xtansia force-pushed the feat/code-gen/generate-to-builder branch from 077fb0f to 4b884f1 Compare November 20, 2024 00:56
@Xtansia Xtansia requested a review from dblock November 20, 2024 00:57
@Xtansia Xtansia force-pushed the feat/code-gen/generate-to-builder branch from 4b884f1 to 7031821 Compare November 21, 2024 03:16
@dblock dblock merged commit fea4138 into opensearch-project:main Nov 21, 2024
55 of 56 checks passed
@Xtansia Xtansia deleted the feat/code-gen/generate-to-builder branch November 21, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants