Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate GetSnapshot #1299

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Conversation

hogesako
Copy link
Contributor

Description

Generate GetSnapshot
opensearch-project/opensearch-api-specification#606

Issues Resolved

GetSnapshot is just an example and may not be resolved.
#420

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tatsuya Kawakami <[email protected]>
Copy link
Collaborator

@Xtansia Xtansia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @hogesako, thank you for picking this up end-to-end! 🙌

This is somewhat tricky from the breaking change perspective, as it's technically breaking, but it is just removing things that were never supported by OpenSearch and were stopping making GetSnapshot requests, so is also really a fix.

If we're wanting to backport this to 2.x, this needs an entry added to the CHANGELOG, otherwise if it's just going in the eventual 3.x it should be documented in UPGRADING.

@reta Do you have any opinions or reservations about backporting this to 2.x?

@reta
Copy link
Collaborator

reta commented Nov 18, 2024

@reta Do you have any opinions or reservations about backporting this to 2.x?

@Xtansia I think everything looks fine except SnapshotInfo that changes quite a few data types. We probably could manually backport it in a backward compatible way, what do you think?

Signed-off-by: Tatsuya Kawakami <[email protected]>
@hogesako hogesako requested a review from Xtansia November 22, 2024 01:03
@hogesako
Copy link
Contributor Author

@Xtansia
I have appended to CHANGELOG.
There is a data types change, is there any other work needed?

Xtansia
Xtansia previously approved these changes Nov 25, 2024
Xtansia
Xtansia previously approved these changes Nov 25, 2024
reta
reta previously approved these changes Nov 25, 2024
Signed-off-by: Thomas Farr <[email protected]>
@Xtansia Xtansia dismissed stale reviews from reta and themself via b567fd2 November 26, 2024 00:34
@Xtansia Xtansia merged commit 1c7c6e0 into opensearch-project:main Nov 26, 2024
56 checks passed
@hogesako
Copy link
Contributor Author

hogesako commented Dec 3, 2024

@Xtansia
Will this PR be backported to 2.x?

@Xtansia Xtansia added the backport 2.x Backport to 2.x branch label Dec 3, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-java/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/opensearch-java/backport-2.x
# Create a new branch
git switch --create backport/backport-1299-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1c7c6e065b22b4a275a335f13eb06aa17ec20a87
# Push it to GitHub
git push --set-upstream origin backport/backport-1299-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-java/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1299-to-2.x.

@Xtansia
Copy link
Collaborator

Xtansia commented Dec 3, 2024

@hogesako It will need to be manually backported but tweaked to minimise breaking changes in 2.x

hogesako added a commit to hogesako/opensearch-java that referenced this pull request Dec 4, 2024
* Generate get snapshot

Signed-off-by: Tatsuya Kawakami <[email protected]>

* add changelog

Signed-off-by: Tatsuya Kawakami <[email protected]>

* Update codegen

Signed-off-by: Thomas Farr <[email protected]>

---------

Signed-off-by: Tatsuya Kawakami <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Co-authored-by: Thomas Farr <[email protected]>
(cherry picked from commit 1c7c6e0)
hogesako added a commit to hogesako/opensearch-java that referenced this pull request Dec 5, 2024
* Generate get snapshot

Signed-off-by: Tatsuya Kawakami <[email protected]>

* add changelog

Signed-off-by: Tatsuya Kawakami <[email protected]>

* Update codegen

Signed-off-by: Thomas Farr <[email protected]>

---------

Signed-off-by: Tatsuya Kawakami <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Co-authored-by: Thomas Farr <[email protected]>
(cherry picked from commit 1c7c6e0)
hogesako added a commit to hogesako/opensearch-java that referenced this pull request Dec 5, 2024
* Generate get snapshot

Signed-off-by: Tatsuya Kawakami <[email protected]>

* add changelog

Signed-off-by: Tatsuya Kawakami <[email protected]>

* Update codegen

Signed-off-by: Thomas Farr <[email protected]>

---------

Signed-off-by: Tatsuya Kawakami <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Co-authored-by: Thomas Farr <[email protected]>
(cherry picked from commit 1c7c6e0)
Xtansia pushed a commit that referenced this pull request Dec 5, 2024
* Generate get snapshot

Signed-off-by: Tatsuya Kawakami <[email protected]>

* add changelog

Signed-off-by: Tatsuya Kawakami <[email protected]>

* Update codegen

Signed-off-by: Thomas Farr <[email protected]>

---------

Signed-off-by: Tatsuya Kawakami <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Co-authored-by: Thomas Farr <[email protected]>
(cherry picked from commit 1c7c6e0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants