Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opensearchapi: Added new struct fields introduced by opensearch 2.12 #482

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

Jakob3xD
Copy link
Collaborator

@Jakob3xD Jakob3xD commented Mar 7, 2024

Description

Adds missing struct fields that fails the validation against latest opensearch

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.26%. Comparing base (34c199e) to head (106106d).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #482       +/-   ##
===========================================
+ Coverage   12.84%   57.26%   +44.41%     
===========================================
  Files         315      315               
  Lines        9823     9823               
===========================================
+ Hits         1262     5625     +4363     
+ Misses       8484     2904     -5580     
- Partials       77     1294     +1217     
Flag Coverage Δ
integration 50.80% <ø> (?)
unit 12.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
opensearchapi/api_cat-indices.go 100.00% <ø> (+100.00%) ⬆️
opensearchapi/api_cat-nodes.go 100.00% <ø> (+100.00%) ⬆️
opensearchapi/api_cat-shards.go 100.00% <ø> (+100.00%) ⬆️
opensearchapi/api_cluster-stats.go 100.00% <ø> (+100.00%) ⬆️
opensearchapi/api_indices-stats.go 83.33% <ø> (+83.33%) ⬆️
opensearchapi/api_nodes-info.go 100.00% <ø> (+100.00%) ⬆️
opensearchapi/api_nodes-stats.go 100.00% <ø> (+100.00%) ⬆️

... and 294 files with indirect coverage changes

@Jakob3xD Jakob3xD changed the title opensearchapi: Added new struct fields introduced from opensearch main opensearchapi: Added new struct fields introduced by opensearch 2.12 Mar 7, 2024
…essage

As opensearch 3.0.0 uses an array instead of string

Signed-off-by: Jakob Hahn <[email protected]>
@Jakob3xD
Copy link
Collaborator Author

Jakob3xD commented Mar 7, 2024

This should fix all workflows except the security one which is handled in #449

@dblock dblock merged commit ee43c33 into opensearch-project:main Mar 7, 2024
48 of 49 checks passed
@Jakob3xD
Copy link
Collaborator Author

Jakob3xD commented Mar 7, 2024

106106d is a type change and therefore a braking change?
If yes then we maybe want to consider stop testing against unrealesed Opensearch as it may bring a lot of braking changes with it and only the changes once we support 3.0.0?

@dblock
Copy link
Member

dblock commented Mar 7, 2024

@Jakob3xD That is being reverted in opensearch-project/OpenSearch#12543

@Jakob3xD Jakob3xD deleted the jh-new-fields branch March 11, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants