Updated test-unit.yml to comment a coverage report #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tanner Jones <[email protected]>
tannerjones4075
requested review from
dblock,
VijayanB,
VachaShah and
Jakob3xD
as code owners
Signed-off-by: Tanner Jones <[email protected]>
Signed-off-by: Tanner Jones <[email protected]>
Signed-off-by: Tanner Jones <[email protected]>
Signed-off-by: Tanner Jones <[email protected]>
Signed-off-by: Tanner Jones <[email protected]>
Signed-off-by: Tanner Jones <[email protected]>
Signed-off-by: Tanner Jones <[email protected]>
dblock
reviewed
Oct 31, 2023
| run: | | ||
| if [ "${{ matrix.os }}" == "ubuntu-latest" ] || [ "${{ matrix.os }}" == "windows-latest" ] || [ "${{ matrix.os }}" == "macOS-latest" ]; then | ||
| curl -sSfL https://codecov.io/bash | bash -s -- -Z -K -f coverage.out || echo "Codecov upload failed" | ||
| fi |
There was a problem hiding this comment.
Feels like this should be the uploader as mentioned in https://about.codecov.io/blog/getting-started-with-code-coverage-for-golang/.
There was a problem hiding this comment.
Ok I will look into that.
| @@ -47,6 +47,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| - Updated Developer guide to include docker build instructions ([#385](https://github.com/opensearch-project/opensearch-go/pull/385) | |||
| - Test against version 2.9.0,2.10.0, run tests in all branches, change intergration tests to wait for OpenSearch to start ([#392](https://github.com/opensearch-project/opensearch-go/pull/392)) | |||
| - Makefile: use docker golangci-lint, run integration test on `.` folder, change coverage generation ([#392](https://github.com/opensearch-project/opensearch-go/pull/392)) | |||
| - test-unit.yml: added PR comment for unit test coverage report ([#407](https://github.com/opensearch-project/opensearch-go/pull/407)) | |||
There was a problem hiding this comment.
This change seems like uploading results to CodeCov, no?
There was a problem hiding this comment.
Yes, I was exploring leveraging CodeCov as it is already being used. Thoughts?
There was a problem hiding this comment.
I am trying to understand the output. Is it running it twice?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Comment coverage report for unit tests coverage
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.