Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Add more params in Search.from_dict() #110

Conversation

WalkerWang731
Copy link

Description

When I use query dict to create a Search object, this function only receive one param, no more params such as using index

Although I can use using() and index() after create object to adjust the object, but these function will copy more object in the s = self._clone() function.

I think these operations are unnecessary.

Reference: #109

Issues Resolved

Add more params in Search.from_dict()

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@VachaShah
Copy link
Collaborator

Hi @WalkerWang731, thank you for contributing! dsl-py client has been merged with the opensearch-py, it is recommended to make any changes in that repo. Please check out https://github.com/opensearch-project/opensearch-py/blob/main/UPGRADING.md for more details.

@Yury-Fridlyand
Copy link
Collaborator

All IT with security fail due to misconfiguration. @VachaShah do you know why? Was it fixed on py client and how?

@VachaShah
Copy link
Collaborator

All IT with security fail due to misconfiguration. @VachaShah do you know why? Was it fixed on py client and how?

@Yury-Fridlyand Not sure why the tests are failing here but all tests in the python client are running fine as of now.

@saimedhi saimedhi closed this Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants