Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove color select on maps document layer setting #935

Closed
wants to merge 1 commit into from

Conversation

junqiu-lei
Copy link
Member

@junqiu-lei junqiu-lei commented Oct 24, 2023

Description

Remove color select on maps document layer setting

local test

       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  plugins/custom-import-map-dashboard      01:54        2        2        -        -        - │
  │    s/documentsLayer.spec.js                                                                    │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        01:54        2        2        -        -        -  

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@SuZhou-Joe
Copy link
Member

@junqiu-lei Seems that the commit is made without -s to signoff, could you please follow the steps described in DCO flow to fix?

@junqiu-lei
Copy link
Member Author

Closing it as #938 resolved the issue

@junqiu-lei junqiu-lei closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants