-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds basic integration test for customImportMap plugin #272
Merged
CCongWang
merged 1 commit into
opensearch-project:main
from
Shivamdhar:functional-test-customImportMap
Aug 4, 2022
Merged
Adds basic integration test for customImportMap plugin #272
CCongWang
merged 1 commit into
opensearch-project:main
from
Shivamdhar:functional-test-customImportMap
Aug 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does it work in FGAC mode? Do tests pass if you run |
CCongWang
reviewed
Aug 4, 2022
Shivamdhar
force-pushed
the
functional-test-customImportMap
branch
2 times, most recently
from
August 4, 2022 19:04
e7761e8
to
35d90d7
Compare
Signed-off-by: Shivam Dhar <[email protected]>
Shivamdhar
force-pushed
the
functional-test-customImportMap
branch
from
August 4, 2022 20:57
35d90d7
to
f1b3fe1
Compare
CCongWang
approved these changes
Aug 4, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 4, 2022
adds integration test for customImportMap plugin Signed-off-by: Shivam Dhar <[email protected]> (cherry picked from commit b4a1f7a)
CCongWang
pushed a commit
that referenced
this pull request
Aug 4, 2022
adds integration test for customImportMap plugin Signed-off-by: Shivam Dhar <[email protected]> (cherry picked from commit b4a1f7a) Co-authored-by: Shivam Dhar <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.2 2.2
# Navigate to the new working tree
cd .worktrees/backport-2.2
# Create a new branch
git switch --create backport/backport-272-to-2.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b4a1f7a1cba7514eccb91a1cc5df807de5d214de
# Push it to GitHub
git push --set-upstream origin backport/backport-272-to-2.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.2 Then, create a pull request where the |
CCongWang
pushed a commit
that referenced
this pull request
Feb 10, 2023
adds integration test for customImportMap plugin Signed-off-by: Shivam Dhar <[email protected]> (cherry picked from commit b4a1f7a) Co-authored-by: Shivam Dhar <[email protected]> Signed-off-by: Cong Wang <[email protected]>
jakubp-eliatra
pushed a commit
to sebastianmichalski/opensearch-dashboards-functional-test
that referenced
this pull request
Mar 24, 2023
) adds integration test for customImportMap plugin Signed-off-by: Shivam Dhar <[email protected]> Signed-off-by: Jakub Przybylski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shivam Dhar [email protected]
Description
Video without security ->
0_before.spec.js.mp4
Test results -
yarn cypress:run-without-security --spec "cypress/integration/plugins/customImportMap/*.js"
Video with security enabled ->
0_before.spec.js.mp4
Test results -
yarn cypress:run-with-security --spec "cypress/integration/plugins/customImportMap/*.js"
Issues Resolved
opensearch-project/dashboards-maps#26
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.