-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using update-alternatives from dpkg to set Java version on Mac agent node #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…node Signed-off-by: Jeff Lu <[email protected]>
Tested on staging enviroment with 3.0.0 (Java21) and build 1.3.15 (Java11), they both looked successful : build 3.0.0
build 1.3.15
|
jordarlu
requested review from
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
prudhvigodithi and
Divyaasm
as code owners
January 3, 2024 17:37
Signed-off-by: Jeff Lu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jordarlu , more comments here. Thanks!
Signed-off-by: Jeff Lu <[email protected]>
Signed-off-by: Jeff Lu <[email protected]>
peterzhuamazon
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are going to use update-alternatives from dpkg to set Java version on Mac agent node
Issues Resolved
opensearch-project/opensearch-build#4272
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.