-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sql, reporting, observability, gantt chart for 1.2 #888
Add sql, reporting, observability, gantt chart for 1.2 #888
Conversation
Codecov Report
@@ Coverage Diff @@
## main #888 +/- ##
=======================================
Coverage 91.58% 91.58%
=======================================
Files 87 87
Lines 2294 2294
=======================================
Hits 2101 2101
Misses 193 193 Continue to review full report at Codecov.
|
I'm fixing CI for the 1.1.0 manifest in #890 |
23a97a3
to
a186cb6
Compare
- name: opensearch-observability | ||
repository: https://github.com/opensearch-project/trace-analytics.git | ||
ref: "main" | ||
working_directory: "opensearch-observability" | ||
checks: | ||
- gradle:properties:version | ||
- gradle:dependencies:opensearch.version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we have new plugin. Adding @peternied as he is looking over 1.2 release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for watching out for this, the repo for trace analytics is being tracked with opensearch-project/observability#118. To what is included or not is up to the repo to manage as they are onboard the release process 👍 .
Unfortunately since this is a new(ish) plugin and it's in a "hybrid" repo it can't use the
After adding that file, I was able to build it. But, I can do it for you if you don't mind me committing on top of your branch. Will need someone from OpenSearch to verify the build since I'm having issues with kNN locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a new build script added for the new component.
a186cb6
to
8b697a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
defe4d0
to
3cd6cd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me on Dashboards side.
Description
schema-version: '1.0'
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.