-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for assembling on Windows. #809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this direction, we are duplicating more configuration files which makes it hard to know if 1.1.0 mac is equivalent to 1.1.0 windows builds and how to tell what the differences are
@@ -0,0 +1,82 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of this manifest duplication, I would much rather we add in a new section platform-restriction
that could be next to components with these more unique attributes
- name: common-utils
repository: https://github.com/opensearch-project/common-utils.git
ref: "1.1"
platform-restriction:
- not:windows // if platform==x do not include
- only:mac // only include if platform==x
- include:solaris // add only if platform==x
checks:
- gradle:publish
- gradle:properties:version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, opened #811 to take care of this. This PR is getting large.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did it in #817, will rebase this change once that's merged.
14e7068
to
ca57932
Compare
f041f50
to
aeaa33a
Compare
Signed-off-by: dblock <[email protected]>
aeaa33a
to
5ce7abf
Compare
Rebased, ready to re-review, maybe @gaiksaya @peternied pls. |
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock [email protected]
Description
opensearch-1.1.0-SNAPSHOT-windows-x64.zip.
, see below for full output.Issues Resolved
Part of #33.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.