Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for only adding modified files in release-notes-check compile script #4927

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

bshien
Copy link
Contributor

@bshien bshien commented Aug 7, 2024

Description

Previously the release-notes-check compile script was only adding modified file, but it was causing fails because the file would be added. This change will fix this.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@bshien bshien force-pushed the release-notes-check-fix branch from 096eae1 to 611a30f Compare August 7, 2024 21:35
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.41%. Comparing base (94a08ed) to head (611a30f).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4927      +/-   ##
==========================================
- Coverage   92.44%   92.41%   -0.04%     
==========================================
  Files         194      197       +3     
  Lines        6528     6634     +106     
==========================================
+ Hits         6035     6131      +96     
- Misses        493      503      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterzhuamazon
Copy link
Member

Not fully getting what is the actual problem.
Could you please give more details?

Thanks.

@gaiksaya gaiksaya merged commit 718af7b into opensearch-project:main Aug 12, 2024
12 checks passed
@bshien
Copy link
Contributor Author

bshien commented Aug 12, 2024

Not fully getting what is the actual problem. Could you please give more details?

Thanks.

The jenkins workflow release-notes-check is failing with the compile parameter because the file that it creates is untracked, when the existing code only adds tracked, modified files. This change fixes that by adding all unstaged changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants