remove sub working directory for gantt-chart #4375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <[email protected]>
joshuali925
requested review from
dblock,
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4375 +/- ##
=======================================
Coverage 91.35% 91.35%
=======================================
Files 190 190
Lines 6197 6197
=======================================
Hits 5661 5661
Misses 536 536 ☔ View full report in Codecov by Sentry. |
|
converting to draft until opensearch-project/dashboards-visualizations#321 gets merged Edit: pending backports opensearch-project/dashboards-visualizations#323, opensearch-project/dashboards-visualizations#325 Edit: removed draft status since all PRs are merged in dashboards-visualizations |
derek-ho
approved these changes
Jan 26, 2024
replied in opensearch-project/dashboards-visualizations#321 (comment) |
|
LGTM |
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
gaiksaya
approved these changes
Feb 3, 2024
prudhvigodithi
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
after opensearch-project/dashboards-visualizations#321, there will be no need to specify build script and working directory.
This is tested on fork using
./build.sh manifests/3.0.0/opensearch-dashboards-3.0.0.yml --component OpenSearch-Dashboards ganttChartDashboards. tested on 3.0.0, 2.12.0, 1.3.14Note
In all future release versions (>=3.0.0, >=2.12.0, >=1.3.15), the manifest file should not include
working_directory: gantt-chart. This seems to be done manually (e.g. #4264). cc. @zelinhIssues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.