Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update geospatial, k-NN, customImportMaps reference from 2.x to 2.4 #2828

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

heemin32
Copy link
Contributor

Description

Update geospatial, k-NN, customImportMaps reference from 2.x to 2.4

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@heemin32 heemin32 requested a review from a team as a code owner October 31, 2022 20:19
@heemin32 heemin32 force-pushed the change_to_2.4 branch 4 times, most recently from 3ce213e to 992be26 Compare October 31, 2022 20:52
@heemin32
Copy link
Contributor Author

Failure is caused by version bump in OpenSearch 2.x branch. opensearch-project/OpenSearch#5002

BUILD SUCCESSFUL in 6m 56s
796 actionable tasks: 795 executed, 1 from cache
2022-10-31 21:01:14 INFO     Executing "./gradlew properties -Dopensearch.version=2.4.0-SNAPSHOT -Dbuild.snapshot=true" in /tmp/tmp_19hbobq/OpenSearch
2022-10-31 21:01:22 INFO     Removing /tmp/tmp_19hbobq
2022-10-31 21:01:24 ERROR    CI Manifest check failed
Traceback (most recent call last):
  File "./src/run_ci.py", line 25, in <module>
    sys.exit(main())
  File "./src/run_ci.py", line 20, in main
    CiManifests.from_file(args.manifest, args).check()
  File "/home/runner/work/opensearch-build/opensearch-build/src/ci_workflow/ci_manifest.py", line 22, in check
    self.__check__()
  File "/home/runner/work/opensearch-build/opensearch-build/src/ci_workflow/ci_input_manifest.py", line 42, in __check__
    ci_check_list.check()
  File "/home/runner/work/opensearch-build/opensearch-build/src/ci_workflow/ci_check_list_source.py", line 45, in check
    instance.check()
  File "/home/runner/work/opensearch-build/opensearch-build/src/ci_workflow/ci_check_gradle_properties_version.py", line 22, in check
    self.properties.check_value("version", self.checked_version)
  File "/home/runner/work/opensearch-build/opensearch-build/src/system/properties_file.py", line 50, in check_value
    raise PropertiesFile.UnexpectedKeyValueError(key, expected, value)
system.properties_file.UnexpectedKeyValueError: Expected to have version='2.4.0-SNAPSHOT', but was '2.5.0-SNAPSHOT'.
Error: Process completed with exit code 1.

@gaiksaya
Copy link
Member

Hi @heemin32 Can you rebase with main and push again?
Thanks!

@gaiksaya gaiksaya merged commit 26fe895 into opensearch-project:main Oct 31, 2022
@heemin32 heemin32 deleted the change_to_2.4 branch October 31, 2022 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants