Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two new plugins to offline scan #2441

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Aug 8, 2022

Signed-off-by: Zelin Hao [email protected]

Description

Add two new plugins (https://github.com/opensearch-project/geospatial
https://github.com/opensearch-project/dashboards-maps) to our whitesource offline jenkins workflow.

Issues Resolved

Part of #2346

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@zelinh zelinh requested a review from a team as a code owner August 8, 2022 23:31
@zelinh zelinh self-assigned this Aug 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2022

Codecov Report

Merging #2441 (5f7358a) into main (abfca2d) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2441   +/-   ##
=========================================
  Coverage     94.62%   94.63%           
  Complexity       27       27           
=========================================
  Files           210      210           
  Lines          4317     4321    +4     
  Branches         29       29           
=========================================
+ Hits           4085     4089    +4     
  Misses          226      226           
  Partials          6        6           
Impacted Files Coverage Δ
src/manifests_workflow/input_manifests.py 99.08% <0.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dblock
Copy link
Member

dblock commented Aug 9, 2022

Is the goal to have all plugins? Maybe we can replace this with enumerating https://github.com/opensearch-project/opensearch-plugins/blob/main/plugins/.meta?

@zelinh
Copy link
Member Author

zelinh commented Aug 9, 2022

Is the goal to have all plugins? Maybe we can replace this with enumerating https://github.com/opensearch-project/opensearch-plugins/blob/main/plugins/.meta?

Not exactly. We still need to perform some local runs before adding them to the scan workflow. For some plugins, we might need further efforts to include them in the scan.

@zelinh zelinh merged commit a8da7f3 into opensearch-project:main Aug 9, 2022
@zelinh zelinh deleted the add-new-plugin-ws branch August 9, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants