Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more components to 2.0.1 manifest and test manifests #2178

Merged
merged 3 commits into from
Jun 10, 2022

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Jun 10, 2022

Signed-off-by: Zelin Hao [email protected]

Description

Add more components to 2.0.1 manifest and test manifests.
After this PR only two OpenSearch plugins (Security, Cross cluster replication) are missing because of opensearch-project/OpenSearch#3554 with Core and security plugin.

Two dashboards plugins need to be added later as well.
opensearch-project/index-management-dashboards-plugin#202
opensearch-project/security-dashboards-plugin#1010

Issues Resolved

Part of #2165

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@zelinh zelinh requested a review from a team as a code owner June 10, 2022 17:57
Signed-off-by: Zelin Hao <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2022

Codecov Report

Merging #2178 (8841b22) into main (7ad040e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2178   +/-   ##
=========================================
  Coverage     94.56%   94.56%           
  Complexity       25       25           
=========================================
  Files           204      204           
  Lines          4253     4253           
  Branches         29       29           
=========================================
  Hits           4022     4022           
  Misses          225      225           
  Partials          6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ad040e...8841b22. Read the comment docs.

@zelinh zelinh force-pushed the add-rest-plugins branch from df7714c to 6ae57b3 Compare June 10, 2022 19:37
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think without security plugin we expect to see build and test failures

@zelinh
Copy link
Member Author

zelinh commented Jun 10, 2022

I think without security plugin we expect to see build and test failures

Security and CCR plugins have been added here! :D
opensearch-project/security#1881

@zelinh zelinh merged commit 1ab874f into opensearch-project:main Jun 10, 2022
@zelinh zelinh deleted the add-rest-plugins branch June 10, 2022 21:51
@gaiksaya
Copy link
Member

gaiksaya commented Jun 10, 2022

Ohh I read this and assumed they aren't
"""
After this PR only two OpenSearch plugins (Security, Cross cluster replication) are missing because of opensearch-project/OpenSearch#3554 with Core and security plugin.
"""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants