Refactor metrics query to use any index and move it under utils #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaiksaya
requested review from
peterzhuamazon,
prudhvigodithi,
rishabh6788,
Divyaasm and
zelinh
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #509 +/- ##
============================================
+ Coverage 84.32% 84.46% +0.14%
Complexity 80 80
============================================
Files 108 108
Lines 523 528 +5
Branches 61 61
============================================
+ Hits 441 446 +5
Misses 26 26
Partials 56 56 ☔ View full report in Codecov by Sentry. |
prudhvigodithi
approved these changes
Sep 26, 2024
Signed-off-by: Sayali Gaikawad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor metrics query to use any index and move it under utils. It can be then used generically to query any indices from metrics cluster. Also modified tests that were using personal fork to use opensearch-project repo URL as an example.
Issues Resolved
part of opensearch-project/opensearch-build#5038
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.