Add tagging feature to npm publishing #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
gaiksaya
requested review from
peterzhuamazon,
prudhvigodithi,
rishabh6788,
Divyaasm and
zelinh
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #492 +/- ##
=========================================
Coverage 84.32% 84.32%
Complexity 80 80
=========================================
Files 108 108
Lines 523 523
Branches 61 61
=========================================
Hits 441 441
Misses 26 26
Partials 56 56 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
| @@ -45,3 +46,10 @@ void parameterCheck(String publicationType, String artifactPath) { | |||
| error('publicationType: github does take any argument with it.') | |||
| } | |||
| } | |||
|
|
|||
| String getNpmTag(String githubTag) { | |||
| def matcher = githubTag =~ /-(\w+)\./ | |||
There was a problem hiding this comment.
Could you explain what exactly are you trying to match with examples for beta tag and latest tag?
Thanks.
There was a problem hiding this comment.
Anything after - in the version number. package.json has a version syntax of 1.0.0-beta.1 or 1.0.0
So just grabbing the same. If there is nothing after major.minor.patch, it defaults to latest
peterzhuamazon
approved these changes
Aug 28, 2024
|
I'll test this on my own npm package before merging this. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Signed-off-by: Sayali Gaikawad <[email protected]> (cherry picked from commit d88c840) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tagging feature to npm publishing. Synced up with @nhtruong offline and confirmed the version syntax for npmjs. Will be parsing the GH tag pushed for tagging the release. Defaults to latest.
Issues Resolved
closes #206
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.