Adapt RubyGems publish action to path changes #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1613af Closes opensearch-project#410 Signed-off-by: Earlopain <[email protected]>
Earlopain
requested review from
peterzhuamazon,
prudhvigodithi,
gaiksaya,
rishabh6788,
Divyaasm and
zelinh
as code owners
There was a problem hiding this comment.
Need version bumping in the build.gradle on patch version.
cc: @gaiksaya
Thanks.
|
Hi @Earlopain |
gaiksaya
approved these changes
Apr 15, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
Signed-off-by: Earlopain <[email protected]> (cherry picked from commit 172c3dd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Merged
|
Thanks for taking care of the bumping! I thought a bot would do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In opensearch-project/opensearch-build@01613af the docker user got changed. As such the users home folder location got changed as well, which didn't get reflected in the rubygems publish action.
This can be seen in the latest publish attempt of
opensearch-ruby: https://build.ci.opensearch.org/blue/organizations/jenkins/opensearch-ruby-gems-release/detail/opensearch-ruby-gems-release/31/pipeline/In order for a ruby version to be selected the path to rvm must be updated. This PR does that by simply using
~, unblocking a new release ofopensearch-ruby.Old output:
New output:
Issues Resolved
Closes #410
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.