Build updates and fix for docker mount issue in v1.9 #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Govind Kamat <[email protected]>
Signed-off-by: Govind Kamat <[email protected]>
gkamat
requested review from
IanHoang,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
IanHoang
reviewed
Sep 13, 2024
Comment on lines
-3
to
-18
| # Licensed to Elasticsearch B.V. under one or more contributor | ||
| # license agreements. See the NOTICE file distributed with | ||
| # this work for additional information regarding copyright | ||
| # ownership. Elasticsearch B.V. licenses this file to you under | ||
| # the Apache License, Version 2.0 (the "License"); you may | ||
| # not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. |
There was a problem hiding this comment.
Should we insert the OpenSearch license?
IanHoang
reviewed
Sep 13, 2024
Comment on lines
-26
to
-28
| ENV PIP_ONLY_BINARY=h5py | ||
| RUN if [ "$BUILD_ENV" = "testing" ] ; then echo Testing; ls -l; python3 -m pip install -e . ; \ | ||
| else echo Production; if [ -z "$VERSION" ] ; then python3 -m pip install opensearch-benchmark ; else python3 -m pip install opensearch-benchmark==$VERSION ; fi; fi |
There was a problem hiding this comment.
We still need this to install OSB in developer mode right?
There was a problem hiding this comment.
Oh nevermind, I see it in the makefile
IanHoang
reviewed
Sep 13, 2024
Comment on lines
+38
to
+47
| For Amazon Linux 2023, run the following command: | ||
| ``` | ||
| sudo yum -y install gcc openssl-devel bzip2-devel libffi-devel ncurses-devel sqlite-devel readline-devel zlib-devel xz-devel | ||
| ``` | ||
|
|
||
| On the Mac platform, XCode needs to be installed as well as some additional required libraries: | ||
| ``` | ||
| xcode-select --install | ||
| brew install pyenv jq zlib xz | ||
| ``` |
There was a problem hiding this comment.
This was needed. Thanks for adding this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry pick of build changes in main, includes fix for #636.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.