Update h5py in dockerfile #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… added some misc. doc edits Signed-off-by: Ian Hoang <[email protected]>
IanHoang
requested review from
gkamat,
beaioun,
cgchinmay and
rishabh6788
as code owners
Move pip3 install in h5py to same line as line that installs OSB. Saves a few MB and doesn't create new layer. Signed-off-by: Ian Hoang <[email protected]>
peterzhuamazon
approved these changes
Apr 25, 2024
gkamat
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently experiencing a block when building the Docker image for OSB. This is because h5py released
3.11.0which seems to have introduced some conflicts. The previous versions of OSB all used h5py3.10.0. There's two approaches we can take to unblock this build error and prevent future build errors:pkg-configandlibhdf5-devin the Dockerfile that are needed by the new h5py version. However, we observed that this had longer build times and we are also not sure if what these dependencies might introduce into OSB.3.10.0(the previous h5py version that OSB has been using in previous versions that works)Since we aren't sure what these new dependencies in the Dockerfile can potentially do, we elected to have strict installation of
3.10.0to prevent future bottlenecks when building the Docker image.Also, added miscellaneous doc updates.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Testing
[Describe how this change was tested]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.