Loosen the dependency version restriction (#499) #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chishui
requested review from
IanHoang,
gkamat,
beaioun,
cgchinmay and
rishabh6788
as code owners
IanHoang
reviewed
Apr 8, 2024
setup.py
Outdated
| "twine>=1.15.0", | ||
| "wheel>=0.38.4", | ||
| "github3.py>=1.3.0", | ||
| "pylint>=2.6.0", |
There was a problem hiding this comment.
Try setting pylint back to == or restrict it to be under 3.X.X as it's currently downloading version 3.1.0 and there's a CI error that seems to be related to Pylint 3.0+ versions
Collecting pylint>=2.6.0 (from opensearch-benchmark==1.5.0)
Downloading pylint-3.1.0-py3-none-any.whl.metadata (12 kB)
Error
ImportError: cannot import name 'IAstroidChecker' from 'pylint.interfaces' (/home/runner/work/opensearch-benchmark/opensearch-benchmark/.venv/lib/python3.8/site-packages/pylint/interfaces.py)
IanHoang
requested changes
Apr 8, 2024
chishui
force-pushed
the
main
branch
2 times, most recently
from
77aab51 to
589a4f8
Compare
|
I only kept the changes in |
Signed-off-by: Liyun Xiu <[email protected]>
IanHoang
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Most of the dependency versions in setup.py are outdated. The PR is to loosen the dependency version restriction so that OSB can be run in the same env with other dependency which requires different dependency version e.g. Jupyter notebook.
Issues Resolved
#499
Testing
New functionality includes testing
make testopensearch-benchmark execute-test ...pip install notebook, then runjupyter notebook, then runopensearch-benchmark execute-test ...again.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.