-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vector search as new operation type to search #423
Conversation
bd6ecd1
to
24d6a96
Compare
24d6a96
to
fd0be1a
Compare
3ad8c71
to
255f245
Compare
@jmazanec15 @navneet1v I removed recall@r, and, kept only recall@k, where, we will compare predictions with top k neighbors from neighbor's list. |
can we have recall@1 always getting calculated? |
255f245
to
af2d85c
Compare
Added recall@1 and updated testcase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple comments
For Vector search, we have to compare actual response's hits with expected neighbors to estimate recall for search. However, there is no provision to return recall similar to throughput. Hence, we will publish recall metrics like recall@k, recall@r as part of meta object. We also time those recall calculation and publish in ms to meta object. Added tests to verify results are as expected. Signed-off-by: Vijayan Balasubramanian <[email protected]>
af2d85c
to
61df791
Compare
Description
For Vector search, we have to compare actual response's hits with expected neighbors to estimate recall for search. However, there is no provision to return recall similar to throughput. Hence, we will publish recall metrics like recall@k, recall@r as part of meta object. We also time those recall calculation and publish in ms to meta object.
Added tests to verify results are as expected.
Issues Resolved
Part of #103
Testing
[Describe how this change was tested]