-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming all occurrences of test-procedure to procedure #421
Renaming all occurrences of test-procedure to procedure #421
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! This is the final piece to the puzzle for our renaming components initiative. I left a few comments. I like how you're creating different commits to address the different variations of Test Procedures.
Yes Ian, that's the plan. I will finish working on the rest of naming tomorrow. And maybe test about its interaction with the workload to see if it will run into any issues. |
Hey, @IanHoang I did manage to rename every occurrence in the repo but failed the integration test over this Error: |
Update: Currently working with Mingyang (@beaioun) on testing these changes out |
95f2a31
to
870326c
Compare
Signed-off-by: beaioun <[email protected]>
Signed-off-by: beaioun <[email protected]>
…e failed integration tests from the last commit Signed-off-by: beaioun <[email protected]>
…etter align with common understandings Signed-off-by: beaioun <[email protected]>
…mple command Signed-off-by: beaioun <[email protected]>
…anches with type names Signed-off-by: beaioun <[email protected]>
9f98d2b
to
8bfbfe4
Compare
Closing this PR as a duplicate has been created |
Description
Renaming all occurrences of the name test-procedure and test_procedure to procedure, class name TestProcedure to Procedure
Issues Resolved
issue #308
Testing
Describe how this change was tested
a unit test was run and more tests will be conducted for the following commit on other test-procedure names.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.