Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming all occurrences of test-procedure to procedure #421

Closed

Conversation

beaioun
Copy link
Collaborator

@beaioun beaioun commented Dec 5, 2023

Description

Renaming all occurrences of the name test-procedure and test_procedure to procedure, class name TestProcedure to Procedure

Issues Resolved

issue #308

Testing

  • New functionality includes testing

Describe how this change was tested

a unit test was run and more tests will be conducted for the following commit on other test-procedure names.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

osbenchmark/metrics.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@IanHoang IanHoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! This is the final piece to the puzzle for our renaming components initiative. I left a few comments. I like how you're creating different commits to address the different variations of Test Procedures.

@beaioun
Copy link
Collaborator Author

beaioun commented Dec 5, 2023

Thanks for this! This is the final piece to the puzzle for our renaming components initiative. I left a few comments. I like how you're creating different commits to address the different variations of Test Procedures.

Yes Ian, that's the plan. I will finish working on the rest of naming tomorrow. And maybe test about its interaction with the workload to see if it will run into any issues.

@beaioun
Copy link
Collaborator Author

beaioun commented Dec 7, 2023

Hey, @IanHoang I did manage to rename every occurrence in the repo but failed the integration test over this Error: [ERROR] Cannot execute-test. Error in test execution orchestrator (Workload 'geonames' is invalid. You must define 'procedure', 'procedures', or 'schedule' but none is specified.) or something similar. I couldn't trace the root cause of this error but it seems to lead to workload/loader.py which is expected as we have discussed.
The next step is maybe to make changes to the workload repo in a safe manner.

@IanHoang
Copy link
Collaborator

Update: Currently working with Mingyang (@beaioun) on testing these changes out

@IanHoang IanHoang changed the base branch from main to renaming-components December 21, 2023 16:55
@beaioun beaioun requested a review from IanHoang December 22, 2023 06:20
@IanHoang
Copy link
Collaborator

Closing this PR as a duplicate has been created

@IanHoang IanHoang closed this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants