Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge into Renaming Components: Rename parameters for Distributed Workload Generation - Issue 258 (#… #414

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

IanHoang
Copy link
Collaborator

@IanHoang IanHoang commented Nov 9, 2023

…407)

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Testing

  • New functionality includes testing

[Describe how this change was tested]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@IanHoang IanHoang requested a review from gkamat as a code owner November 9, 2023 20:14
Copy link
Collaborator

@gkamat gkamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more readable with the new terminology! Thanks for the change.

Comment on lines +2248 to +2251
"Parameter source "
"for operation 'create-ingest-pipeline' "
"did not provide the "
"mandatory parameter 'body'. "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps two lines should suffice for the strings to fit in about a terminal width (80 chars)?

@IanHoang IanHoang merged commit 7a7fa3a into renaming-components Nov 14, 2023
7 of 8 checks passed
IanHoang added a commit to IanHoang/opensearch-benchmark that referenced this pull request Jul 23, 2024
…d Generation - Issue 258 (#… (opensearch-project#414)

Signed-off-by: vivek palakkat <[email protected]>
Co-authored-by: dosa_chammandi <[email protected]>
Co-authored-by: Maddox Schmidlkofer <[email protected]>
cgchinmay pushed a commit to cgchinmay/opensearch-benchmark that referenced this pull request Aug 29, 2024
…d Generation - Issue 258 (#… (opensearch-project#414)

Signed-off-by: vivek palakkat <[email protected]>
Co-authored-by: dosa_chammandi <[email protected]>
Co-authored-by: Maddox Schmidlkofer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants