Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecates generate chart command #393

Merged
merged 8 commits into from
Oct 17, 2023
Merged

Deprecates generate chart command #393

merged 8 commits into from
Oct 17, 2023

Conversation

AkshathRaghav
Copy link
Contributor

@AkshathRaghav AkshathRaghav commented Oct 11, 2023 •
edited
Loading

Description

Deprecates generate chart command

Issues Resolved

#384

Testing

  • Tested with make it and make test
  py38: commands succeeded
  py39: commands succeeded
  py310: commands succeeded
  py311: commands succeeded
  congratulations :)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AkshathRaghav
Adding documentation
58eb1e4 
Signed-off-by: AkshathRaghav <[email protected]>
@AkshathRaghav
Updating docs
2a2511c 
Signed-off-by: AkshathRaghav <[email protected]>
@AkshathRaghav
Removing generate files
7ed92da 
Signed-off-by: AkshathRaghav <[email protected]>
@AkshathRaghav
Tested
28f03e8 
Signed-off-by: AkshathRaghav <[email protected]>
@AkshathRaghav
Correcting import error
cb98699 
Signed-off-by: AkshathRaghav <[email protected]>
@AkshathRaghav
Making changes to documentation
f72507a 
Signed-off-by: AkshathRaghav <[email protected]>
@AkshathRaghav
Retrying unit tests
6620f29 
Signed-off-by: AkshathRaghav <[email protected]>
IanHoang
IanHoang reviewed Oct 13, 2023
View reviewed changes
setup.py Show resolved Hide resolved
IanHoang
IanHoang reviewed Oct 13, 2023
View reviewed changes
DEVELOPER_GUIDE.md Outdated Show resolved Hide resolved
IanHoang
IanHoang requested changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@IanHoang IanHoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments

@AkshathRaghav
Removing files from tracking
86c1d68 
Signed-off-by: AkshathRaghav <[email protected]>
@IanHoang IanHoang merged commit 62eface into opensearch-project:main Oct 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanHoang IanHoang IanHoang approved these changes

@gkamat gkamat Awaiting requested review from gkamat gkamat is a code owner

Assignees

@AkshathRaghav AkshathRaghav

Labels
None yet
Projects
OpenSearch Benchmark OSCI
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AkshathRaghav @IanHoang