Extend Sigv4 to Role based Access #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ran a test mode with this feature yesterday with geonames workload and confirmed with @cgchinmay that scroll API error was due to cluster settings. |
gkamat
approved these changes
Oct 15, 2023
tests/metrics_test.py
Outdated
| @@ -319,6 +328,9 @@ def config_opts_parsing_aws_creds(self, configuration_source, override_datastore | |||
| _datastore_aws_service = random.choice(['es', 'aoss']) | |||
| _datastore_aws_region = random.choice(['us-east-1', 'eu-west-1']) | |||
|
|
|||
| # optional | |||
| _datastore_aws_session_token = "".join([random.choice(string.ascii_letters + string.digits) for _ in range(752)]) | |||
There was a problem hiding this comment.
Specify 752 as a declared constant.
cgchinmay
force-pushed
the
sigv4-role-based
branch
from
2210789 to
5c1a879
Compare
Signed-off-by: Chinmay Gadgil <[email protected]>
cgchinmay
force-pushed
the
sigv4-role-based
branch
from
5c1a879 to
328f352
Compare
Signed-off-by: Chinmay Gadgil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
extend sigv4 support to role-based access
Issues Resolved
#377
Testing
[Describe how this change was tested]
Added new UT
Updated existing UT
validated by running
make testvalidated by provisioning a managed cluster and verifying access with session-token
validated by running benchmark test using http_logs
Note
Scroll API request in OSB becnhmark test is failing and is currently being investigated
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.