Fix for point in time #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "search", | ||
| "paginated-search", |
There was a problem hiding this comment.
The code for paginated-search functionality is already present in the code base, though the paginated-search was not enabled for CompositeContext.
dhruv16dhr
reviewed
Aug 22, 2022
Arpit-Bandejiya
requested review from
dhruv16dhr and
bharath-techie
and removed request for
dhruv16dhr and
bharath-techie
|
Hi @achitojha, @engechas , please take a look at this PR. |
dhruv16dhr
approved these changes
Aug 23, 2022
|
|
||
|
|
||
| class ClosePointInTime(Runner): | ||
| class DeletePointInTime(Runner): |
There was a problem hiding this comment.
I remember us discussing to have deleteAllPointInTime outside composite context - lets see if we can add that as well to code repository.
achitojha
reviewed
Aug 23, 2022
Comment on lines
-64
to
-65
| register_runner(workload.OperationType.OpenPointInTime, OpenPointInTime(), async_runner=True) | ||
| register_runner(workload.OperationType.ClosePointInTime, ClosePointInTime(), async_runner=True) |
There was a problem hiding this comment.
Can we confirm none of the workloads here do not use these operations
There was a problem hiding this comment.
Yes, I have checked and verified that these operations are not called in the workloads repo as of now
| opensearch.list_all_point_in_time.return_value = as_future({ | ||
| "pits": [ | ||
| { | ||
| "pitId": pit_id, |
There was a problem hiding this comment.
this i think will be changed to "pit_id" as that is followed everywhere. Lets wait for rest PRs to go in.
| @@ -4403,9 +4403,9 @@ async def test_creates_point_in_time(self, opensearch): | |||
| "index": "test-index" | |||
| } | |||
|
|
|||
| opensearch.open_point_in_time.return_value = as_future({"id": pit_id}) | |||
| opensearch.create_point_in_time.return_value = as_future({"id": pit_id}) | |||
There was a problem hiding this comment.
same here , this might become "pit_id" - lets wait for rest prs to merge.
Arpit-Bandejiya
force-pushed
the
pittesting
branch
from
eb5fde6 to
850ba65
Compare
Signed-off-by: Arpit Bandejiya <[email protected]>
Signed-off-by: Arpit Bandejiya <[email protected]>
Signed-off-by: Arpit Bandejiya <[email protected]>
Signed-off-by: Arpit Bandejiya <[email protected]>
Signed-off-by: Arpit Bandejiya <[email protected]>
Signed-off-by: Arpit Bandejiya <[email protected]>
Arpit-Bandejiya
force-pushed
the
pittesting
branch
from
08a58ad to
ab08098
Compare
Signed-off-by: Arpit Bandejiya <[email protected]>
bharath-techie
approved these changes
Oct 19, 2022
Signed-off-by: Arpit Bandejiya <[email protected]>
|
Just to follow up on Achit's comment, has this been tested on a test workload? Given that the integration tests are failing (but due to a separate cause), it'd be worth testing this on a test workload and supply the results. |
|
Thanks @IanHoang for the feedback, have uploaded the test results. Also the |
IanHoang
approved these changes
Oct 26, 2022
Signed-off-by: Arpit Bandejiya <[email protected]>
Signed-off-by: Arpit Bandejiya <[email protected]>
travisbenedict
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes the point in time functionality
[Describe what this change achieves]
Fix Issue
#4187
Testing
[Describe how this change was tested]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.