CorePluginSourceDownloader Migration #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chase Engelbrecht <[email protected]>
Signed-off-by: Chase Engelbrecht <[email protected]>
Signed-off-by: Chase Engelbrecht <[email protected]>
achitojha
reviewed
Apr 7, 2022
…. Remove member class initialization in constructor in favor of passing in as args for factory pattern Signed-off-by: Chase Engelbrecht <[email protected]>
weifenh
approved these changes
Apr 11, 2022
|
|
||
|
|
||
| class SourceBinaryBuilder(BinaryBuilder): | ||
| def __init__(self, executor, path_manager, jdk_resolver, source_directory, build_jdk, log_directory): |
There was a problem hiding this comment.
I'd rename it as build_jdk_version, but up to you. The naming build_jdk mostly makes sense, it's about the jdk version, but there's a slight chance that people may think it's a boolean first then figure out "build a JDK" wound not make sense here.
There was a problem hiding this comment.
That's a good callout, will rename
Signed-off-by: Chase Engelbrecht <[email protected]>
Comment on lines
14
to
17
| ;param host: A host object representing the machine on which to run the commands | ||
| ;param build_commands: A list of strings representing sequential bash commands used to build the binaries | ||
| ;param override_source_directory: A string representing the source directory where the pre-binary code is located | ||
| ;return None |
There was a problem hiding this comment.
Nit: Should these semicolons be colons?
There was a problem hiding this comment.
Yes. Not sure where I picked up the semi-colon thing but I've made that mistake elsewhere too. Will fix this instance then blanket refactor the rest in a followup PR
travisbenedict
approved these changes
Apr 11, 2022
Signed-off-by: Chase Engelbrecht <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates the CorePluginSourceDownloader. Also implements a help class
SourceBuilderIssues Resolved
#134
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.