Implement ExceptionHandlingInstaller #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chase Engelbrecht <[email protected]>
achitojha
approved these changes
Apr 5, 2022
travisbenedict
approved these changes
Apr 5, 2022
| try: | ||
| return self.installer.install(host, binaries, all_node_ips) | ||
| except Exception as e: | ||
| raise InstallError("Installing node on host \"{}\" failed".format(host), e) |
There was a problem hiding this comment.
Nit: I think f-strings are the standard now for Python string formatting. Sorry if I missed this on other PRs
raise InstallError(f"Installing node on host \"{host}\" failed", e)
There was a problem hiding this comment.
Didn't know that. Will fix the instances here then swap out the rest of the occurrences in a followup PR
Signed-off-by: Chase Engelbrecht <[email protected]>
weifenh
approved these changes
Apr 5, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds ExceptionHandlingInstaller as decorator for top-level exception handling
Signed-off-by: Chase Engelbrecht [email protected]
Issues Resolved
#134
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.