Create Repository helper classes to be consumed by the Downloaders #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chase Engelbrecht <[email protected]>
weifenh
approved these changes
Apr 4, 2022
osbenchmark/builder/downloaders/repositories/opensearch_distribution_repository_provider.py
Show resolved
Hide resolved
travisbenedict
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the following helper classes:
OpenSearchDistributionRepositoryProvider,PluginDistributionRepositoryProvider, andRepositoryUrlProvider. These classes will be used by the Downloaders for fetching the distributions from a given repository.Additionally, the TemplateRenderer was refactored to have 2 methods:
render_template_fileandrender_template_string.Signed-off-by: Chase Engelbrecht [email protected]
Issues Resolved
#134
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.