Add Provider and Flavor enums, populate their default values in ProvisionConfigInstance #163
Conversation
…sionConfigInstance Signed-off-by: Chase Engelbrecht <[email protected]>
| from enum import Enum | ||
|
|
||
|
|
||
| class Provider(str, Enum): |
There was a problem hiding this comment.
How do you feel about calling this something like InfraProvider or ClusterInfraProvider instead?
There was a problem hiding this comment.
That's more clear, will change
| from enum import Enum | ||
|
|
||
|
|
||
| class Flavor(str, Enum): |
There was a problem hiding this comment.
Thoughts on calling this ClusterFlavor instead?
There was a problem hiding this comment.
That's more clear, will change
Signed-off-by: Chase Engelbrecht <[email protected]>
|
|
||
| class ClusterFlavor(str, Enum): | ||
| SELF_MANAGED = "self_managed" | ||
| MANAGED = "managed" |
There was a problem hiding this comment.
Do we need two different enums for ClusterFlavor & ClusterInfraProvider? Can you explain what's the use case supporting the need for two enums.
I was thinking of combining them into one. The MANAGED flavor seems too generic for me, similarly LOCAL provider probably doesn't add much value.
There was a problem hiding this comment.
They are used in tandem to define the cluster, i.e.
Local + self managed
AWS + self managed
AWS + managed
GCP + managed
While they could be combined into a single enum, separating them will allow easier parsing of the provision config instance file variables when there is commonality across a ClusterInfraProvider type regardless of the ClusterFlavor or vice versa.
The planned structure for PCI file variables is <ClusterInfraProvider>.<ClusterFlavor>.xyz where a special keyword common can be supplied in place of either to act as a wildcard.
A concrete example of this would look something like
[config]
cluster_infra_provider = aws
...
[variables]
aws.common.security_enabled=true
...
By having ClusterInfraProvider as a standalone enum, it becomes very simple to pick up this variable as relevant to the given scenario since we can match on ClusterInfraProvider == aws
There was a problem hiding this comment.
Discussed offline, I recommended merging the enums into one and having provider and favor attributes to it. However, the current form work well for me too.
Description
Adds the new Provider and Flavor models for the build system expansion.
#132
Signed-off-by: Chase Engelbrecht [email protected]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.