Skip to content

Commit

Permalink
Adding operation for enabling concurrent segment search
Browse files Browse the repository at this point in the history
Signed-off-by: Martin Gaievski <[email protected]>
  • Loading branch information
martin-gaievski committed Jul 23, 2024
1 parent df46b4a commit 08db823
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 0 deletions.
14 changes: 14 additions & 0 deletions osbenchmark/worker_coordinator/runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -2696,3 +2696,17 @@ async def __call__(self, opensearch, params):

def __repr__(self, *args, **kwargs):
return "deploy-ml-model"

class EnableConcurrentSegmentSearch(Runner):
@time_func
async def __call__(self, opensearch, params):
enable_setting = params.get("enable", "false")
body = {
"transient": {
"search.concurrent_segment_search.enabled": enable_setting
}
}
await opensearch.cluster.put_settings(body=body)

def __repr__(self, *args, **kwargs):
return "enable-concurrent-segment-search"
3 changes: 3 additions & 0 deletions osbenchmark/workload/workload.py
Original file line number Diff line number Diff line change
Expand Up @@ -635,6 +635,7 @@ class OperationType(Enum):
DeleteMlModel = 1041
RegisterMlModel = 1042
DeployMlModel = 1043
EnableConcurrentSegmentSearch = 1044

@property
def admin_op(self):
Expand Down Expand Up @@ -752,6 +753,8 @@ def from_hyphenated_string(cls, v):
return OperationType.TrainKnnModel
elif v == "delete-knn-model":
return OperationType.DeleteKnnModel
elif v == "enable-concurrent-segment-search":
return OperationType.EnableConcurrentSegmentSearch
else:
raise KeyError(f"No enum value for [{v}]")

Expand Down
20 changes: 20 additions & 0 deletions tests/worker_coordinator/runner_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -6785,3 +6785,23 @@ async def test_param_id_mandatory(self, opensearch, on_client_request_start, on_
await r(opensearch, params)

self.assertEqual(0, opensearch.transport.perform_request.call_count)

class EnableConcurrentSegmentSearchTests(TestCase):
@mock.patch('osbenchmark.client.RequestContextHolder.on_client_request_end')
@mock.patch('osbenchmark.client.RequestContextHolder.on_client_request_start')
@mock.patch("opensearchpy.OpenSearch")
@run_async
async def test_enable_concurrent_segment_search(self, opensearch, on_client_request_start, on_client_request_end):
opensearch.cluster.put_settings.return_value = as_future()
params = {
"enable": "true"
}

r = runner.EnableConcurrentSegmentSearch()
await r(opensearch, params)

opensearch.cluster.put_settings.assert_called_once_with(body={
"transient": {
"search.concurrent_segment_search.enabled": "true"
}
})

0 comments on commit 08db823

Please sign in to comment.