-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add standard value sources to nyc_taxis to allow using range query randomization #368
Merged
IanHoang
merged 1 commit into
opensearch-project:main
from
peteralfonsi:nyc-taxis-aug-main
Aug 28, 2024
Merged
Add standard value sources to nyc_taxis to allow using range query randomization #368
IanHoang
merged 1 commit into
opensearch-project:main
from
peteralfonsi:nyc-taxis-aug-main
Aug 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Alfonsi <[email protected]>
peteralfonsi
requested review from
IanHoang,
gkamat,
beaioun,
cgchinmay,
rishabh6788 and
VijayanB
as code owners
August 16, 2024 16:37
IanHoang
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is clean. Thanks for contributing this!
IanHoang
added
backport 2
Backport to the "2" branch
backport 3
Backport to the "3" branch
backport 1
labels
Aug 28, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> (cherry picked from commit 45207c5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> (cherry picked from commit 45207c5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]> (cherry picked from commit 45207c5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
IanHoang
pushed a commit
that referenced
this pull request
Aug 29, 2024
(cherry picked from commit 45207c5) Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Peter Alfonsi <[email protected]>
IanHoang
pushed a commit
that referenced
this pull request
Aug 29, 2024
(cherry picked from commit 45207c5) Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Peter Alfonsi <[email protected]>
IanHoang
pushed a commit
that referenced
this pull request
Aug 29, 2024
(cherry picked from commit 45207c5) Signed-off-by: Peter Alfonsi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Peter Alfonsi <[email protected]>
joshpalis
pushed a commit
to joshpalis/opensearch-benchmark-workloads
that referenced
this pull request
Dec 18, 2024
Signed-off-by: Peter Alfonsi <[email protected]> Co-authored-by: Peter Alfonsi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
opensearch-project/opensearch-benchmark#455 introduced logic to controllably randomize range queries, which is useful for testing caching behavior. This requires registering "standard value sources" for each operation, which produce a random gte/lte value for the query.
This PR adds these for nyc_taxis, so you don't have to use a custom version of the workload in your own fork. These standard value sources have no effect if the flag
--randomization-enabled
isn't used. (See the randomizer code).This PR is a first step towards adding a nightly benchmark using randomization. This will help us catch cache-related performance issues.
Tested with randomization both on and off, and saw no errors.
Randomization on:
opensearch-benchmark execute-test --pipeline=benchmark-only --workload-path=/home/ec2-user/osb/opensearch-benchmark-workloads/nyc_taxis --workload-params='{"requests_cache_enabled":"true"}' --target-host=http://localhost:9200 --randomization-enabled --randomization-repeat-frequency 0.3 --randomization-n 10000 --randomization-alpha 0.9 --throughput-percentiles 0,25,50,75,100 --latency-percentiles 0,10,20,25,30,40,50,60,70,75,80,90,99,99.9,99.99,100 --test-mode
Randomization off:
opensearch-benchmark execute-test --pipeline=benchmark-only --workload-path=/home/ec2-user/osb/opensearch-benchmark-workloads/nyc_taxis --target-host=http://localhost:9200 --throughput-percentiles 0,25,50,75,100 --latency-percentiles 0,10,20,25,30,40,50,60,70,75,80,90,99,99.9,99.99,100 --test-mode
Issues Resolved
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.