Added test for POST /{index}/_mapping
#745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tokesh <[email protected]>
Tokesh
changed the title
POST /{index}/_mapping
Changes AnalysisCommit SHA: 5f7e41f API ChangesSummaryNO CHANGES ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12397988594/artifacts/2338971786 API Coverage
|
Spec Test Coverage Analysis
|
|
Dont merge this PR please! :) |
Tokesh
requested review from
dblock,
harshavamsi,
sachetalva,
nhtruong,
Xtansia,
VachaShah and
aabeshov
as code owners
dblock
approved these changes
Dec 18, 2024
dblock
requested changes
Dec 18, 2024
| acknowledged: true | ||
| - synopsis: Add or update mapping using POST method. |
There was a problem hiding this comment.
This is a bit redundant with what's above. Change the first PUT /{index}/_mapping to having two verbs, PUT and POST instead.
|
Test coverage looks suspicious :)
|
Signed-off-by: Tokesh <[email protected]>
Signed-off-by: Tokesh <[email protected]>
dblock
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
POST /{index}/_mapping
Issues Resolved
[#663]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.