Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate snapshot schema naming #730

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Dec 13, 2024

Description

Disambiguate snapshot schema naming

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Xtansia Xtansia force-pushed the snapshot-schema-naming branch from a34d7b6 to 48f1707 Compare December 13, 2024 04:45
Copy link
Contributor

github-actions bot commented Dec 13, 2024

Changes Analysis

Commit SHA: 48f1707
Comparing To SHA: dd7fd9a

API Changes

Summary

├─┬Paths
│ ├─┬/_snapshot/{repository}/{snapshot}/_status
│ │ └─┬GET
│ │   └─┬Responses
│ │     └─┬200
│ │       └─┬application/json
│ │         └─┬Schema
│ │           └─┬snapshots
│ │             └─┬Schema
│ │               └──[🔀] $ref (58829:13)❌ 
│ ├─┬/_snapshot/{repository}/_status
│ │ └─┬GET
│ │   └─┬Responses
│ │     └─┬200
│ │       └─┬application/json
│ │         └─┬Schema
│ │           └─┬snapshots
│ │             └─┬Schema
│ │               └──[🔀] $ref (58829:13)❌ 
│ └─┬/_snapshot/_status
│   └─┬GET
│     └─┬Responses
│       └─┬200
│         └─┬application/json
│           └─┬Schema
│             └─┬snapshots
│               └─┬Schema
│                 └──[🔀] $ref (58829:13)❌ 
└─┬Components
  ├──[➖] schemas (58633:7)❌ 
  ├──[➖] schemas (58829:7)❌ 
  ├──[➖] schemas (58661:7)❌ 
  ├──[➖] schemas (58698:7)❌ 
  ├──[➖] schemas (58678:7)❌ 
  ├──[➕] schemas (58747:7)
  ├──[➕] schemas (58719:7)
  ├──[➕] schemas (58784:7)
  ├──[➕] schemas (58764:7)
  ├──[➕] schemas (58829:7)
  ├─┬snapshot._common___SnapshotShardsStatus
  │ ├─┬stats
  │ │ └──[🔀] $ref (58764:13)❌ 
  │ └─┬stage
  │   └──[🔀] $ref (58748:9)❌ 
  └─┬snapshot._common___SnapshotIndexStats
    └─┬shards_stats
      └──[🔀] $ref (58719:13)❌ 

Document Element Total Changes Breaking Changes
paths 3 3
components 13 8
  • BREAKING Changes: 11 out of 16
  • Modifications: 6
  • Removals: 5
  • Additions: 5
  • Breaking Removals: 5
  • Breaking Modifications: 6

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12309753349/artifacts/2315580127

API Coverage

Before After Δ
Covered (%) 606 (59.35 %) 606 (59.35 %) 0 (0 %)
Uncovered (%) 415 (40.65 %) 415 (40.65 %) 0 (0 %)
Unknown 43 43 0

Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
536 487 (90.86 %)

@dblock dblock merged commit ebe0f8a into opensearch-project:main Dec 13, 2024
28 checks passed
@Xtansia Xtansia deleted the snapshot-schema-naming branch December 15, 2024 20:53
nathaliellenaa pushed a commit to nathaliellenaa/opensearch-api-specification that referenced this pull request Dec 18, 2024
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants