Fix query DSL types #706

Xtansia · 2024-12-05T03:08:27Z

Description

Fix query DSL types

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2024-12-05T03:10:40Z

Changes Analysis

Commit SHA: 6118309
Comparing To SHA: 0ee21a8

API Changes

Summary

├─┬Paths
│ ├─┬/{index}/_explain/{id}
│ │ ├─┬GET
│ │ │ └──Parameters
│ │ └─┬POST
│ │   └──Parameters
│ ├─┬/_validate/query
│ │ ├─┬GET
│ │ │ └──Parameters
│ │ └─┬POST
│ │   └──Parameters
│ ├─┬/{index}/_search
│ │ ├─┬GET
│ │ │ └──Parameters
│ │ └─┬POST
│ │   └──Parameters
│ ├─┬/{index}/_update_by_query
│ │ └─┬POST
│ │   └──Parameters
│ ├─┬/{index}/_count
│ │ ├─┬GET
│ │ │ └──Parameters
│ │ └─┬POST
│ │   └──Parameters
│ ├─┬/{index}/_delete_by_query
│ │ └─┬POST
│ │   └──Parameters
│ ├─┬/_search
│ │ ├─┬GET
│ │ │ └──Parameters
│ │ └─┬POST
│ │   └──Parameters
│ ├─┬/_count
│ │ ├─┬GET
│ │ │ └──Parameters
│ │ └─┬POST
│ │   └──Parameters
│ ├─┬/{index}/_validate/query
│ │ ├─┬GET
│ │ │ └──Parameters
│ │ └─┬POST
│ │   └──Parameters
│ └─┬/_template/{name}
│   ├─┬PUT
│   │ └─┬Requestbody
│   │   └─┬application/json
│   │     └─┬Schema
│   │       ├─┬order
│   │       │ ├──[🔀] type (26558:23)❌ 
│   │       │ └──[➕] format (26559:25)❌ 
│   │       └─┬settings
│   │         └──[🔀] additionalProperties (26563:39)❌ 
│   └─┬POST
│     └─┬Requestbody
│       └─┬application/json
│         └─┬Schema
│           ├─┬order
│           │ ├──[🔀] type (26558:23)❌ 
│           │ └──[➕] format (26559:25)❌ 
│           └─┬settings
│             └──[🔀] additionalProperties (26563:39)❌ 
└─┬Components
  ├──[➖] schemas (41646:7)❌ 
  ├──[➖] schemas (42521:7)❌ 
  ├──[➖] schemas (32810:7)❌ 
  ├──[➖] schemas (32892:7)❌ 
  ├──[➖] schemas (32130:7)❌ 
  ├──[➖] schemas (42588:7)❌ 
  ├──[➖] schemas (42609:7)❌ 
  ├──[➖] schemas (42226:7)❌ 
  ├──[➖] schemas (32467:7)❌ 
  ├──[➖] schemas (33608:7)❌ 
  ├──[➖] schemas (32126:7)❌ 
  ├──[➖] schemas (42563:7)❌ 
  ├──[➕] schemas (42651:7)
  ├──[➕] schemas (32135:7)
  ├──[➕] schemas (42244:7)
  ├──[➕] schemas (32155:7)
  ├──[➕] schemas (39738:7)
  ├──[➕] schemas (41167:7)
  ├──[➕] schemas (42662:7)
  ├─┬_common.query_dsl___Operator
  │ ├──[➕] enum (41803:11)
  │ └──[➕] enum (41805:11)
  ├─┬_core.search___InnerHits
  │ ├──[➕] properties (44336:9)
  │ └──[➖] properties (44240:9)❌ 
  ├─┬_common___DistanceUnit
  │ ├──[➖] enum (31948:11)❌ 
  │ ├──[➖] enum (31949:11)❌ 
  │ ├──[➖] enum (31950:11)❌ 
  │ ├──[➖] enum (31953:11)❌ 
  │ ├──[➖] enum (31954:11)❌ 
  │ ├──[➖] enum (31955:11)❌ 
  │ ├──[➖] enum (31956:11)❌ 
  │ ├──[➖] enum (31951:11)❌ 
  │ ├──[➖] enum (31952:11)❌ 
  │ ├──[➖] type (31946:13)❌ 
  │ ├──[➕] oneOf (31962:11)
  │ ├──[➕] oneOf (31971:11)
  │ ├──[➕] oneOf (31956:11)
  │ ├──[➕] oneOf (31953:11)
  │ ├──[➕] oneOf (31965:11)
  │ ├──[➕] oneOf (31968:11)
  │ ├──[➕] oneOf (31959:11)
  │ ├──[➕] oneOf (31947:11)
  │ └──[➕] oneOf (31950:11)
  ├─┬indices._common___TemplateMapping
  │ ├─┬order
  │ │ ├──[🔀] type (50216:17)❌ 
  │ │ └──[➕] format (50217:19)❌ 
  │ └─┬settings
  │   └──[🔀] additionalProperties (50220:33)❌ 
  ├─┬_core.search___SourceConfig
  │ ├──[➖] oneOf (44549:7)❌ 
  │ └─┬ONEOF
  │   └──[🔀] $ref (44642:9)❌ 
  ├─┬_common.query_dsl___QueryContainer
  │ ├──[➖] properties (41948:9)❌ 
  │ ├──[➖] properties (42002:9)❌ 
  │ ├──[➖] properties (42011:9)❌ 
  │ ├─┬fuzzy
  │ │ └──[➕] propertyNames (41950:13)❌ 
  │ ├─┬neural
  │ │ └──[🔀] $ref (42042:11)❌ 
  │ ├─┬prefix
  │ │ └──[➕] propertyNames (42059:13)❌ 
  │ ├─┬term
  │ │ ├──[➕] propertyNames (42123:13)❌ 
  │ │ └─┬Schema
  │ │   └──[🔀] $ref (42635:9)❌ 
  │ ├─┬terms_set
  │ │ └──[➕] propertyNames (42137:13)❌ 
  │ ├─┬match_phrase
  │ │ └──[➕] propertyNames (42019:13)❌ 
  │ ├─┬knn
  │ │ └──[🔀] $ref (41981:11)❌ 
  │ ├─┬regexp
  │ │ └──[➕] propertyNames (42081:13)❌ 
  │ ├─┬wildcard
  │ │ └──[➕] propertyNames (42148:13)❌ 
  │ ├─┬span_term
  │ │ └──[➕] propertyNames (42110:13)❌ 
  │ ├─┬range
  │ │ └──[➕] propertyNames (42070:13)❌ 
  │ ├─┬match_phrase_prefix
  │ │ └──[➕] propertyNames (42030:13)❌ 
  │ ├─┬common
  │ │ └──[➕] propertyNames (41929:13)❌ 
  │ ├─┬terms
  │ │ └──[🔀] $ref (42663:9)❌ 
  │ ├─┬match_bool_prefix
  │ │ └──[➕] propertyNames (42008:13)❌ 
  │ ├─┬intervals
  │ │ └──[➕] propertyNames (41975:13)❌ 
  │ └─┬match
  │   ├──[➕] propertyNames (41994:13)❌ 
  │   └─┬Schema
  │     └──[🔀] $ref (41530:9)❌ 
  ├─┬_common___MultiTermQueryRewrite
  │ ├──[➖] enum (32594:11)❌ 
  │ ├──[➖] enum (32595:11)❌ 
  │ ├──[➖] enum (32590:11)❌ 
  │ ├──[➖] enum (32591:11)❌ 
  │ ├──[➖] enum (32592:11)❌ 
  │ ├──[➖] enum (32593:11)❌ 
  │ ├──[➖] type (32588:13)❌ 
  │ ├──[➕] oneOf (32585:11)
  │ └──[➕] oneOf (32580:11)
  ├─┬_common.query_dsl___KnnQuery
  │ ├──[➖] additionalProperties (41301:9)❌ 
  │ ├──[➖] type (41299:13)❌ 
  │ ├──[➖] maxProperties (41303:22)❌ 
  │ ├──[➖] minProperties (41302:22)❌ 
  │ ├──[➕] allOf (41906:7)
  │ └──[➕] allOf (41357:11)
  ├─┬_common___SortOptions
  │ ├──[➖] type (33626:13)❌ 
  │ ├──[➖] maxProperties (33637:22)❌ 
  │ ├──[➖] minProperties (33636:22)❌ 
  │ ├──[➖] properties (33630:9)❌ 
  │ ├──[➖] properties (33632:9)❌ 
  │ ├──[➖] properties (33628:9)❌ 
  │ ├──[➖] properties (33634:9)❌ 
  │ ├──[➕] oneOf (33597:11)
  │ ├──[➕] oneOf (33615:11)
  │ ├──[➕] oneOf (33593:11)
  │ ├──[➕] oneOf (33603:11)
  │ └──[➕] oneOf (33595:11)
  ├─┬_common.query_dsl___LikeDocument
  │ ├──[➕] properties (41416:9)
  │ └─┬doc
  │   └──[➖] type (41314:17)❌ 
  ├─┬_common___Sort
  │ ├─┬ONEOF
  │ │ └─┬Schema
  │ │   └──[🔀] $ref (33593:9)❌ 
  │ └─┬ONEOF
  │   └──[🔀] $ref (33593:9)❌ 
  ├─┬_common.query_dsl___MatchQuery
  │ ├──[➖] allOf (41800:7)❌ 
  │ ├──[➖] allOf (41424:11)❌ 
  │ ├──[➕] oneOf (32162:7)
  │ └──[➕] oneOf (41532:11)
  ├─┬_common.query_dsl___WildcardQuery
  │ ├──[➖] allOf (41800:7)❌ 
  │ ├──[➖] allOf (42625:11)❌ 
  │ ├──[➕] oneOf (42716:11)
  │ └──[➕] oneOf (42714:11)
  ├─┬_common.query_dsl___MatchAllQuery
  │ └──[🔀] $ref (41429:7)❌ 
  ├─┬_common___FieldValue
  │ └──[🔀] type (32164:9)❌ 
  ├─┬_common.query_dsl___FieldAndFormat
  │ ├──[➖] required (40852:11)❌ 
  │ ├──[➖] type (40842:13)❌ 
  │ ├──[➖] properties (40844:9)❌ 
  │ ├──[➖] properties (40846:9)❌ 
  │ ├──[➖] properties (40849:9)❌ 
  │ ├──[➕] oneOf (40889:11)
  │ └──[➕] oneOf (32093:7)
  ├─┬_common.query_dsl___PercolateQuery
  │ ├─┬ALLOF
  │ │ └──[🔀] $ref (41906:13)❌ 
  │ └─┬ALLOF
  │   └──[🔀] $ref (41821:11)❌ 
  ├─┬_common.query_dsl___MatchPhraseQuery
  │ ├──[➖] allOf (41800:7)❌ 
  │ ├──[➖] allOf (41405:11)❌ 
  │ ├──[➕] oneOf (41510:11)
  │ └──[➕] oneOf (41508:11)
  ├─┬_core.search___SourceFilter
  │ ├──[➖] type (44549:13)❌ 
  │ ├──[➖] properties (44551:9)❌ 
  │ ├──[➖] properties (44553:9)❌ 
  │ ├──[➕] oneOf (32120:7)
  │ └──[➕] oneOf (44644:11)
  ├─┬_common.query_dsl___Like
  │ └─┬ONEOF
  │   └──[➕] title (41399:18)
  ├─┬_common.query_dsl___PrefixQuery
  │ ├──[➖] allOf (41785:11)❌ 
  │ ├──[➖] allOf (41800:7)❌ 
  │ ├──[➕] oneOf (41887:11)
  │ └──[➕] oneOf (41889:11)
  ├─┬_common.query_dsl___RegexpQuery
  │ ├──[➖] allOf (41800:7)❌ 
  │ ├──[➖] allOf (42204:11)❌ 
  │ ├──[➕] oneOf (42336:11)
  │ └──[➕] oneOf (42338:11)
  ├─┬nodes.info___NodeInfoSettingsPlugins
  │ └──[🔀] additionalProperties (55147:29)❌ 
  ├─┬_common.query_dsl___MatchPhrasePrefixQuery
  │ ├──[➖] allOf (41800:7)❌ 
  │ ├──[➖] allOf (41382:11)❌ 
  │ ├──[➕] oneOf (41484:11)
  │ └──[➕] oneOf (41482:11)
  ├─┬_common.query_dsl___MatchBoolPrefixQuery
  │ ├──[➕] oneOf (41435:11)
  │ ├──[➕] oneOf (41437:11)
  │ ├──[➖] allOf (41800:7)❌ 
  │ └──[➖] allOf (41338:11)❌ 
  ├─┬_common.query_dsl___SimpleQueryStringFlags
  │ ├──[➖] allOf (32810:7)❌ 
  │ ├──[➕] oneOf (42414:11)
  │ └──[➕] oneOf (42394:7)
  ├─┬_common.query_dsl___CommonTermsQuery
  │ ├──[➖] allOf (41800:7)❌ 
  │ ├──[➖] allOf (40710:11)❌ 
  │ ├──[➕] oneOf (40750:11)
  │ └──[➕] oneOf (40752:11)
  ├─┬_common.query_dsl___SpanTermQuery
  │ ├──[➖] allOf (41800:7)❌ 
  │ ├──[➖] allOf (42488:11)❌ 
  │ ├──[➕] oneOf (42613:11)
  │ └──[➕] oneOf (42611:11)
  ├─┬_common.query_dsl___FuzzyQuery
  │ ├──[➖] allOf (41800:7)❌ 
  │ ├──[➖] allOf (40955:11)❌ 
  │ ├──[➕] oneOf (32162:7)
  │ └──[➕] oneOf (41003:11)
  ├─┬_core.search___HighlightField
  │ ├─┬ALLOF
  │ │ └──[🔀] $ref (44208:11)❌ 
  │ └─┬ALLOF
  │   └──[🔀] $ref (44089:13)❌ 
  ├─┬_common.query_dsl___TermsQueryField
  │ ├──[➖] additionalProperties (42542:9)❌ 
  │ ├──[➖] type (42532:13)❌ 
  │ ├──[➖] properties (42534:9)❌ 
  │ ├──[➕] oneOf (42673:11)
  │ └──[➕] oneOf (42651:7)
  ├─┬_common.query_dsl___NeuralQuery
  │ ├─┬ALLOF
  │ │ └──[🔀] $ref (41906:13)❌ 
  │ └─┬ALLOF
  │   └──[🔀] $ref (41749:11)❌ 
  ├─┬_core.search___HighlightBase
  │ ├──[➕] properties (44112:9)
  │ └──[➕] properties (44126:9)
  ├─┬_common.query_dsl___TermQuery
  │ ├──[➖] allOf (42509:11)❌ 
  │ ├──[➖] allOf (41800:7)❌ 
  │ ├──[➕] oneOf (32162:7)
  │ └──[➕] oneOf (42637:11)
  └─┬_core.search___BuiltinHighlighterType
    ├──[➖] enum (43834:11)❌ 
    ├──[➖] enum (43835:11)❌ 
    ├──[➖] enum (43836:11)❌ 
    ├──[➖] type (43832:13)❌ 
    ├──[➕] oneOf (43926:11)
    ├──[➕] oneOf (43931:11)
    └──[➕] oneOf (43928:11)

Document Element	Total Changes	Breaking Changes
components	183	124
paths	6	6

❌ BREAKING Changes: 130 out of 189
Modifications: 23
Removals: 84
Additions: 82
Breaking Removals: 84
Breaking Modifications: 23
Breaking Additions: 17

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12188891790/artifacts/2282017536

API Coverage

	Before	After	Δ
Covered (%)	599 (58.67 %)	599 (58.67 %)	0 (0 %)
Uncovered (%)	422 (41.33 %)	422 (41.33 %)	0 (0 %)
Unknown	42	42	0

Signed-off-by: Thomas Farr <[email protected]>

github-actions · 2024-12-05T22:12:33Z

Spec Test Coverage Analysis

Total	Tested
528	423 (80.11 %)

Xtansia requested review from dblock, harshavamsi, sachetalva, nhtruong, VachaShah, Tokesh and aabeshov as code owners December 5, 2024 03:08

Xtansia force-pushed the fix/query-dsl-types branch 2 times, most recently from 93a6275 to 59452b3 Compare December 5, 2024 03:10

Xtansia marked this pull request as draft December 5, 2024 03:13

Xtansia force-pushed the fix/query-dsl-types branch 5 times, most recently from 0c96598 to 6179e64 Compare December 5, 2024 22:02

Fix query DSL types

6118309

Signed-off-by: Thomas Farr <[email protected]>

Xtansia force-pushed the fix/query-dsl-types branch from 6179e64 to 6118309 Compare December 5, 2024 22:09

Xtansia marked this pull request as ready for review December 5, 2024 22:12

dblock approved these changes Dec 6, 2024

View reviewed changes

dblock merged commit bbc0d9a into opensearch-project:main Dec 6, 2024
29 checks passed

Xtansia deleted the fix/query-dsl-types branch December 8, 2024 21:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix query DSL types #706

Fix query DSL types #706

Xtansia commented Dec 5, 2024

github-actions bot commented Dec 5, 2024 •

edited

Loading

github-actions bot commented Dec 5, 2024

Fix query DSL types #706

Fix query DSL types #706

Conversation

Xtansia commented Dec 5, 2024

Description

github-actions bot commented Dec 5, 2024 • edited Loading

Changes Analysis

API Changes

Summary

Report

API Coverage

github-actions bot commented Dec 5, 2024

Spec Test Coverage Analysis

github-actions bot commented Dec 5, 2024 •

edited

Loading