-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index Search Template
API tests
#702
Conversation
Signed-off-by: Tokesh <[email protected]>
Search Template
API tests
Changes AnalysisCommit SHA: c8f5b15 API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12124975377/artifacts/2262992706 API Coverage
|
Spec Test Coverage Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, do add to CHANGELOG.
Signed-off-by: Tokesh <[email protected]>
@dblock Thank you! ready for your review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to be annoying. Let's put these tests in the right place?
/{index}/_search/template
-> tests/default/indices/search/template.yaml
/_search/template
-> tests/default/search/template.yaml
Signed-off-by: Tokesh <[email protected]>
Signed-off-by: Tokesh <[email protected]>
It doesn't annoy! Thank you |
Description
test for:
GET /{index}/_search/template
POST /{index}/_search/template
GET /_search/template
POST /_search/template
Issues Resolved
[#663]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.