Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index Search Template API tests #702

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

Tokesh
Copy link
Collaborator

@Tokesh Tokesh commented Dec 1, 2024

Description

test for:
GET /{index}/_search/template
POST /{index}/_search/template
GET /_search/template
POST /_search/template

Issues Resolved

[#663]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Tokesh Tokesh changed the title adding tests for search templates Index Search Template API tests Dec 1, 2024
Copy link
Contributor

github-actions bot commented Dec 1, 2024

Changes Analysis

Commit SHA: c8f5b15
Comparing To SHA: c400057

API Changes

Summary

└─┬Paths
  ├─┬/{index}/_search/template
  │ ├─┬GET
  │ │ └─┬Responses
  │ │   └─┬200
  │ │     └─┬application/json
  │ │       └─┬Schema
  │ │         └──[➕] properties (30447:15)
  │ └─┬POST
  │   └─┬Responses
  │     └─┬200
  │       └─┬application/json
  │         └─┬Schema
  │           └──[➕] properties (30447:15)
  └─┬/_search/template
    ├─┬GET
    │ └─┬Responses
    │   └─┬200
    │     └─┬application/json
    │       └─┬Schema
    │         └──[➕] properties (30447:15)
    └─┬POST
      └─┬Responses
        └─┬200
          └─┬application/json
            └─┬Schema
              └──[➕] properties (30447:15)

Document Element Total Changes Breaking Changes
paths 4 0
  • Total Changes: 4
  • Additions: 4

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12124975377/artifacts/2262992706

API Coverage

Before After Δ
Covered (%) 599 (58.67 %) 599 (58.67 %) 0 (0 %)
Uncovered (%) 422 (41.33 %) 422 (41.33 %) 0 (0 %)
Unknown 42 42 0

@Tokesh Tokesh added the skip-changelog No need to update CHANGELOG. label Dec 1, 2024
Copy link
Contributor

github-actions bot commented Dec 1, 2024

Spec Test Coverage Analysis

Total Tested
528 419 (79.36 %)

@Tokesh Tokesh marked this pull request as ready for review December 1, 2024 08:52
@dblock dblock removed the skip-changelog No need to update CHANGELOG. label Dec 1, 2024
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, do add to CHANGELOG.

spec/namespaces/_core.yaml Show resolved Hide resolved
Signed-off-by: Tokesh <[email protected]>
@Tokesh Tokesh requested a review from dblock December 2, 2024 16:38
@Tokesh
Copy link
Collaborator Author

Tokesh commented Dec 2, 2024

@dblock Thank you! ready for your review!

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be annoying. Let's put these tests in the right place?

/{index}/_search/template -> tests/default/indices/search/template.yaml
/_search/template -> tests/default/search/template.yaml

@Tokesh
Copy link
Collaborator Author

Tokesh commented Dec 2, 2024

Sorry to be annoying. Let's put these tests in the right place?

/{index}/_search/template -> tests/default/indices/search/template.yaml /_search/template -> tests/default/search/template.yaml

It doesn't annoy! Thank you

@Tokesh Tokesh requested a review from dblock December 2, 2024 17:47
@dblock dblock merged commit d3c8d65 into opensearch-project:main Dec 2, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants