-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced all indices with indexes. #671
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes AnalysisCommit SHA: 535d92e API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11841565344/artifacts/2188745144 API Coverage
|
Spec Test Coverage Analysis
|
dblock
force-pushed
the
indices-indexes
branch
6 times, most recently
from
November 13, 2024 20:08
8e8ff53
to
7ee9ff3
Compare
dblock
requested review from
harshavamsi,
sachetalva,
nhtruong,
Xtansia,
VachaShah,
Tokesh and
aabeshov
as code owners
November 13, 2024 20:10
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
dblock
force-pushed
the
indices-indexes
branch
from
November 14, 2024 16:38
7ee9ff3
to
535d92e
Compare
@nhtruong care to take a look pls? |
nhtruong
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces all "indices" with "indexes".
There's a debate whether this is right in opensearch-project/documentation-website#8696, but in the meantime this standardizes the language to match what we have in the documentation and runs a Vale pass on many descriptions and avoids tripping lots of future contributions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.