Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected /{index}/_create/{id} 201 response. #669

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Nov 13, 2024

Description

A successful response from /{index}/_create/{id} is always a 201 it seems like.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Nov 13, 2024

Changes Analysis

Commit SHA: fdc97ae
Comparing To SHA: fce5721

API Changes

Summary

├─┬Paths
│ └─┬/{index}/_create/{id}
│   ├─┬PUT
│   │ └─┬Responses
│   │   ├──[➕] codes (28041:7)
│   │   └──[➖] codes (28041:7)❌ 
│   └─┬POST
│     └─┬Responses
│       ├──[➕] codes (28041:7)
│       └──[➖] codes (28041:7)❌ 
└─┬Components
  ├──[➕] responses (28041:7)
  └──[➖] responses (28041:7)❌ 

Document Element Total Changes Breaking Changes
paths 4 2
components 2 1
  • BREAKING Changes: 3 out of 6
  • Removals: 3
  • Additions: 3
  • Breaking Removals: 3

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11824258702/artifacts/2183897263

API Coverage

Before After Δ
Covered (%) 588 (57.59 %) 588 (57.59 %) 0 (0 %)
Uncovered (%) 433 (42.41 %) 433 (42.41 %) 0 (0 %)
Unknown 40 40 0

Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
515 344 (66.8 %)

@Xtansia Xtansia merged commit 2cdd46a into opensearch-project:main Nov 13, 2024
24 checks passed
@dblock dblock deleted the create-api branch November 13, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants