Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made NestedAggregate inherit from AggregateBase #632

Conversation

nhtruong
Copy link
Collaborator

@nhtruong nhtruong commented Oct 21, 2024

Description

Made NestedAggregate inherit from AggregateBase instead of SingleBucketAggregateBase to resolve doc_count conflict where the schema is a union of 2 different objects with conflicting requirement for properties doc_type (one says it's optional while the other says it's required)

This conflict is causing an error on the Node.js client generator.

  • Tests have already been provided in a previous commit that updated this schema.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…etAggregateBase to resolve `doc_count` requirement conflict

Signed-off-by: Theo Truong <[email protected]>
@nhtruong nhtruong added the skip-changelog No need to update CHANGELOG. label Oct 21, 2024
Copy link
Contributor

Changes Analysis

Commit SHA: dd7df64
Comparing To SHA: e95e7d3

API Changes

Summary

└─┬Components
  └─┬_common.aggregations:NestedAggregate
    └─┬ALLOF
      └──[🔀] $ref (32342:13)❌ 

Document Element Total Changes Breaking Changes
components 1 2
  • BREAKING Changes: 2 out of 1
  • Modifications: 1
  • Breaking Modifications: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11444817573/artifacts/2083605149

API Coverage

Before After Δ
Covered (%) 588 (57.59 %) 588 (57.59 %) 0 (0 %)
Uncovered (%) 433 (42.41 %) 433 (42.41 %) 0 (0 %)
Unknown 29 29 0

Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
504 317 (62.9 %)

@dblock dblock merged commit 56081a4 into opensearch-project:main Oct 21, 2024
20 of 30 checks passed
@nhtruong nhtruong deleted the fix/common.aggregations/NestedAggregate branch October 22, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No need to update CHANGELOG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants